search

clipmove / NotBlood

Gameplay Mod For NBlood
https://github.com/clipmove/NotBlood/releases
59 stars 3 forks source link

[Question] Rationale Behind Removing Blood directory auto-detection #71

Closed OpenRift412 closed 10 months ago

OpenRift412 commented 10 months ago

I recall a while ago you removed the ability for NotBlood to detect directories that Blood is stored in outside the one that NotBlood's executable exists in. What was the reasoning behind this removal? I recall you mentioning something about it either in the commit or somewhere else, but I can't seem to find it.

tmyqlfpir commented 10 months ago

The reason was that NotBlood would mount Fresh Supply's directory wholesale, which given that there are some mods that include versions for Fresh Supply, will conflict when trying to use the same mod in NotBlood's directory. To avoid conflictions, and potential issues when loading files using the same filenames, it was removed.

While I understand this makes it more inconvenient for first time users, it will solve a potential problem for users who have both Fresh Supply installed and want to use NotBlood with mods.

OpenRift412 commented 10 months ago

Hey @tmyqlfpir, so now that Fresh Supply on Steam comes with the DOS version, would it be more viable to re-introduce auto-detection?

tmyqlfpir commented 10 months ago

Upstream code will need to be rewritten, but sure, I'll re-evaluate my decision when the gog version is updated (only because I don't have steam).

OpenRift412 commented 10 months ago

Upstream code will need to be rewritten, but sure, I'll re-evaluate my decision when the gog version is updated (only because I don't have steam).

Are they planning on updating the GOG version? The GOG version of Fresh Supply comes with OUWB as a separate installer. So it's included when you buy Fresh Supply on GOG, just not with the installation of Fresh Supply.

tmyqlfpir commented 10 months ago

Are they planning on updating the GOG version?

I assumed it will be updated along side Steam, but that may be optimism on my part. If they do decide to update GoG I'll revisit my decision here. For now the install guide is the only method of playing NotBlood, and does not result in any potential conflicts when installing different mods for Fresh Supply and NotBlood.

Edit: Browsing across NBlood issues, I came across this one. https://github.com/nukeykt/NBlood/issues/405 This seems more of a better idea to keep the detection removed as it avoids conflicting installed mods.