cloud-atlas-ai / obsidian-ics

Generate Daily Planner from ical feeds
MIT License
139 stars 27 forks source link

bug: recurring all-day events aren't added #112

Closed Cateroo closed 6 months ago

Cateroo commented 7 months ago

Thanks for the great plugin, I just wanted to report a bug that I seem to be facing with use:

All-day events that are recurring (I tested with recurring annually on date) do not show up on the calendar events list. Timed recurring events are fine, and all-day events are fine, but somehow when those two are combined they fail to get listed by the plugin.

This basically means I'm not getting birthday reminders, which is less than optimal 😅

muness commented 7 months ago

Hi Cateroo, do you have any other details? I get All Day events (from my Google calendar feeds) fine, though sometimes timezones are offset.

Also, can you double check the day before and after to make sure the events don't show up there instead?

Cateroo commented 7 months ago

Hi Muness,

I have checked the previous and next days. The events aren't there either.

What details would you like? I've tried different calendars (home calendar and other side calendars) but nothing works.

Just to be clear, all day events work fine, it's only when they're recurring all-day events that they don't show up. (recurring timed events are also fine)

-C

Cateroo commented 7 months ago

To update, I tried a bunch of trouble shooting with help from people on the obsidian discord, but no change. This is the code I'm using -

<% var events = await app.plugins.getPlugin('ics').getEvents(moment(tp.file.title,"DD MMM YYYY")); console.table(events); events.sort((a,b) => a.utime - b.utime).forEach((e) => { const calendar = e.icsName.replace(" ","-"); const callUrl = e.callUrl? ` ${e.callType}` : ''; const location = e.location? ` 📍(${e.location})*` : ''; tR+=`- [ ] #${calendar}:: ${e.time}-${e.endTime} : \`${e.summary} ${calendar}\`${location}${callUrl}\n` }) %>

it seems to work for others using similar/same code, but it doesn't work for me. have tried it with different calendars and operating systems, but nothing works.

Cateroo commented 7 months ago

I have attached a sample event that is all-day recurring that is not pulled in my app. please let me know if this works, because it is not getting pulled by my code. invite.zip

Edit: I have now tried doing this in a new vault with no additional plugins, and using a new calendar. Neither works to pull recurring-all-day events. would really appreciate help with this.

The1029 commented 6 months ago

+1, I am experiencing the same issue. I've checked the days before/after but I'm not seeing anything. This appears to include both new events set to recur at later dates, and recurrences of previous events. If it helps, I am using NextCloud as my provider.

@muness, I cloned the repo to see if I could figure out what was going on, and miraculously things started working. Looking at version numbers, installing from community plugins appears to use 1.6.1 rather than the latest release (1.6.3 at time of writing). Is there any discrepancy between the two versions that could explain this? And is there any way to update the community repo? Must admit, I have so far only developed plugins locally without submission to community, so I'm unsure of how this should work.

Cateroo commented 6 months ago

Thanks for finding the issue - I'm also seeing the version on mine as 1.6.1 - it doesn't show any updates on checking using the obsidian option.

I guess that means I'll have to use Bart to reinstall and check if that works.

The1029 commented 6 months ago

I can see that the version was recently bumped to 1.6.4 and this now appears to be reflecting in the community repo - I've just tested with a clean install from there and these are displaying correctly for me now.