search

cloudflare / tableflip

Graceful process restarts in Go
BSD 3-Clause "New" or "Revised" License
2.91k stars 148 forks source link

loop reload failed #63

Closed flyaways closed 3 years ago

flyaways commented 3 years ago

loop always miss first args

1 start: procname -c xxx.conf

2 reload: kill -HUP parent pid

3 look proc: ps aux|grep ${procname} or lsof -p parent pid

child args is -c xxx.conf it's wrong

4 continue reload: kill -HUP child pid

reload failed

lmb commented 3 years ago

hi @flyaways, can you test against v1.2.2 please? That version has https://github.com/cloudflare/tableflip/commit/9fd66fb495501f213e91b585e291d5fa76f7e166 which should fix the issue.

flyaways commented 3 years ago

this pr is good than v1.2.2 fix

lmb commented 3 years ago

Sorry, I don't understand. Which of these are you saying:

  1. This PR is better than v1.2.2
  2. This PR is as good as v1.2.2
flyaways commented 3 years ago

close