cloudflare / workerd

The JavaScript / Wasm runtime that powers Cloudflare Workers
https://blog.cloudflare.com/workerd-open-source-workers-runtime/
Apache License 2.0
6.29k stars 307 forks source link

Web Platform Tests #2862

Open kflansburg opened 1 month ago

kflansburg commented 1 month ago
anonrig commented 3 weeks ago

@npaun It seems assert_throws_js implementation is wrong. Here's the Node.js implementation: https://github.com/nodejs/node/blob/8807549ed9f6eaf6842ae56b8ac55ab385951636/test/fixtures/wpt/resources/testharness.js#L2046

Completed in https://github.com/cloudflare/workerd/pull/3157

anonrig commented 3 weeks ago

Additional issue: @npaun If a test is in expected_failures but if it doesn't fail, we should also throw an error.

Completed in https://github.com/cloudflare/workerd/pull/3157

npaun commented 3 weeks ago

Yep that's an excellent idea.