search

cloudflare / workerd

The JavaScript / Wasm runtime that powers Cloudflare Workers
https://blog.cloudflare.com/workerd-open-source-workers-runtime/
Apache License 2.0
6.29k stars 309 forks source link

Revert "Merge pull request #2970 from cloudflare/kenton/sqlite-statem… #3115

Closed justin-mp closed 1 week ago

justin-mp commented 1 week ago

…ent-cache-3"

This reverts commit 9326b8a5c1bdf5cef9616d750d56b5f7152c3ed0, reversing changes made to bbde7e4f9352be729c0daa379d23a9ecbea44585.

We believe that the SQLite query cache has lead to a latency increase for many workloads.

danlapid commented 1 week ago

Does this require a matching internal pr?

justin-mp commented 1 week ago

Does this require a matching internal pr?

Yes. See 9194. I needed to push this to know what PR number to include in the internal PR.

kentonv commented 1 week ago

This could break anyone who has become dependent on the ability to pass multiple statements at a time to D1's prepare() API.

isaac-mcfadyen commented 1 week ago

This could break anyone who has become dependent on the ability to pass multiple statements at a time to D1's prepare() API.

FWIW we see this frequently from users on the Cloudflare Developers Discord so definitely a valid concern.

justin-mp commented 1 week ago

See #3117 for a better fix.