cloudflare / workerd

The JavaScript / Wasm runtime that powers Cloudflare Workers
https://blog.cloudflare.com/workerd-open-source-workers-runtime/
Apache License 2.0
6.28k stars 304 forks source link

[CI] Fix macOS release configuration #3133

Closed fhanau closed 4 days ago

fhanau commented 4 days ago

The macOS-ARM64 configuration would overwrite the macOS-X64 definition based on how matrix includes work since target-arch is not part of the original matrix configuration. This way we now have macOS-ARM64, but are suddenly missing macOS-X64. Fix this by adding target-arch to the default matrix configuration so that a new configuration is created with the target-arch: ARM64 directive.

=================

See https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#expanding-or-adding-matrix-configurations for documentation/an example on how the include rules work