Closed making closed 6 years ago
Hey making!
Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.
We have created an issue in Pivotal Tracker to manage this:
https://www.pivotaltracker.com/story/show/159586577
The labels on this github issue will be updated when the story is started.
Hi @making
Is there any particular reason you would like it deployed as the manifest addon and not use runtime config?
@alex-slynko For the user who just wants to manage kubernetes with bosh and foward logs related to only k8s, configuring log forwarding is not a separation of concerns. Runtime config seems too wide. Using include
or exclude
in a separated file is not comfortable.
I think this is just as same as other deployments suppport syslog forwarding:
Hi @making
Could you please fix the unit tests for manifest interpolation?
It is ./bin/run_tests
.
You can add sample variables in https://github.com/cloudfoundry-incubator/kubo-deployment/tree/master/manifests/ops-files/example-vars-files
@alex-slynko Fixed
@making you can pass multiple ops-files to the test. See for example https://github.com/cloudfoundry-incubator/kubo-deployment/pull/338/files#diff-18093856d0498026e07aa1435ad1eea3L39
@alex-slynko Put two ops-files to one check_interpolation
What this PR does / why we need it:
This PR adds ops-file to enable syslog forwarding with syslog-release.
How can this PR be verified?
Configure a syslog endpoint in
add-syslog.yml
andadd-syslog-tls.yml
(if TLS is required) and check whether component logs (such as kube-apiserver) are received in the syslog server.Is there any change in kubo-release?
No
Is there any change in kubo-ci?
No
Does this affect upgrade, or is there any migration required?
No
Which issue(s) this PR fixes:
Forwarding component logs to a syslog endpoint
Release note: