search

cloudfoundry-incubator / kubo-deployment

Contains manifests used to deploy Cloud Foundry Container Runtime
https://www.cloudfoundry.org/container-runtime/
Apache License 2.0
275 stars 114 forks source link

Add ops-file to change etcd's metrics url #343

Closed making closed 6 years ago

making commented 6 years ago

What this PR does / why we need it:

This PR add an ops file to change etcd's metrics url so that operator can use a separate port and protocol for the metrics endpoint.

How can this PR be verified? run ./bin/run_tests

Is there any change in kubo-release? no

Is there any change in kubo-ci? no

Does this affect upgrade, or is there any migration required? no

Which issue(s) this PR fixes:

related to https://github.com/cloudfoundry-incubator/cfcr-etcd-release/pull/9

Release note:

Added ops-files to change the protocol and port of the metrics endpoint of etcd.
cfdreddbot commented 6 years ago

Hey making!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/160486233

The labels on this github issue will be updated when the story is started.

iainsproat commented 6 years ago

Thanks @making - I've triggered our CI pipeline to run the unit tests: https://ci.kubo.sh/teams/main/pipelines/kubo-deployment-pr/jobs/run-unit-tests/builds/25