search

cloudfoundry-incubator / kubo-deployment

Contains manifests used to deploy Cloud Foundry Container Runtime
https://www.cloudfoundry.org/container-runtime/
Apache License 2.0
275 stars 114 forks source link

Support configurable cloud-config #353

Closed tvs closed 5 years ago

tvs commented 5 years ago

What this PR does / why we need it: This PR supports the configurable cloud-config exposed in https://github.com/cloudfoundry-incubator/kubo-release/pull/263 by updating the various ops-files.

How can this PR be verified? Deploy with a cloud-provider and observe that the manifest renders into the expected INI file. Follow up by using a cloud-provider specific bit of functionality like a Load Balancer or Persistent Volume.

Is there any change in kubo-release? Yes.

Is there any change in kubo-ci? No.

Does this affect upgrade, or is there any migration required? Not generally, unless operators are using custom ops-files to enable other cloud-provider options not covered by the default ops-files.

Those operators will need to rewrite the ops-file to move the option to the new format.

Which issue(s) this PR fixes: https://www.pivotaltracker.com/story/show/161421611

Release note:

* The Kubernetes Cloud Config now accepts pass-through arguments from the BOSH manifest. See kubo-deployment/manifest/ops-files/iaas/<iaas>/cloud-provider.yml for examples.
  * As a result of this change, certain behaviors of the release will no longer occur:
    * In vSphere, the manifest property will need to handle escapes in the username and password fields.
    * In GCP, token-url must explicitly be set to 'nil' when supplying a service-key. See kubo-deployment/manifest/ops-files/iaas/gcp/add-service-key-master.yml for an example.
    * In OpenStack, supplying the OpenStack CA file does _not_ override the OpenStack CA file path. The path needs to be hardcoded into the cloud-config option. By default, that path is `/var/vcap/jobs/cloud-provider/config/openstack-ca.crt`
cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/161461564

The labels on this github issue will be updated when the story is started.

cfdreddbot commented 5 years ago

Hey tvs!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.