search

cloudfoundry-incubator / kubo-deployment

Contains manifests used to deploy Cloud Foundry Container Runtime
https://www.cloudfoundry.org/container-runtime/
Apache License 2.0
275 stars 114 forks source link

Ops-files for controlling deployment name and kubo version. #376

Closed benmoss closed 5 years ago

benmoss commented 5 years ago

Signed-off-by: Leah Hanson lhanson@pivotal.io

What this PR does / why we need it: Adds ops-files for controlling deployment name and kubo version.

When deploying multiple clusters on the same bosh director, it is necessary to give them different names and sometimes to specify different kubo versions for each one. These ops-files make it easier to change these settings because you can put the values in vars-files rather than changing the base manifest manually every time.

How can this PR be verified? Use these opsfiles, see that you can create a deployment named something other than cfcr or with an arbitrary version.

Is there any change in kubo-deployment? No

Is there any change in kubo-ci? No

Does this affect upgrade, or is there any migration required? No

Release note:

NONE
cfdreddbot commented 5 years ago

:white_check_mark: Hey benmoss! The commit authors and yourself have already signed the CLA.

alex-slynko commented 5 years ago

Hi @benmoss

We have ops-file to rename deployment: https://github.com/cloudfoundry-incubator/kubo-deployment/blob/master/manifests/ops-files/rename.yml and two ops-files to use custom kubo-release versions: https://github.com/cloudfoundry-incubator/kubo-deployment/blob/master/manifests/ops-files/misc/dev.yml - use latest. https://github.com/cloudfoundry-incubator/kubo-deployment/blob/master/manifests/ops-files/kubo-local-release.yml - use local repo.

In general, we don't support using custom final versions and dev versions should be covered by two ops-files. We have also a separate ops-file in our CI for testing purposes: https://github.com/cloudfoundry-incubator/kubo-ci/blob/master/manifests/ops-files/set-kubo-release-version.yml Feel free to reuse it for your tests.