search

cloudfoundry-incubator / kubo-deployment

Contains manifests used to deploy Cloud Foundry Container Runtime
https://www.cloudfoundry.org/container-runtime/
Apache License 2.0
275 stars 114 forks source link

Add opsfile to up fs.inotify limit to allow more file watchers #382

Closed Benjamintf1 closed 5 years ago

Benjamintf1 commented 5 years ago

Signed-off-by: Brady Love blove@pivotal.io

What this PR does / why we need it: We used this opsfile to up the fs.inotify limit such that fluent-bit's tail plugin does not overwhelm the fs inotify limit. This was added to the master for future work. How can this PR be verified? cat /proc/sys/fs/inotify/max_user_watches shows 65k watches /etc/sysctl.d/71-bosh-os-conf-sysctl.conf shows this line as well. Is there any change in kubo-release? No Is there any change in kubo-ci? We didn't add any changes, but can if needed for testing etc. Does this affect upgrade, or is there any migration required? No Which issue(s) this PR fixes: https://www.pivotaltracker.com/story/show/164228988 Release note:

Added a opsfile to up fs.inotify limit for log watching.
cfdreddbot commented 5 years ago

:white_check_mark: Hey Benjamintf1! The commit authors and yourself have already signed the CLA.

pgoodwin commented 5 years ago

Is there any way to write a test for this?

wfernandes commented 5 years ago

@pgoodwin Could you point us to a place where such tests exist for verifying ops-files? We don't mind adding a test for this specific ops-file. Thanks.

wfernandes commented 5 years ago

@pgoodwin Actually I see a spec directory with a single test. Is this what you are referring to?

Just read through the CONTRIBUTING.md. Will update our PR. Thanks.

pgoodwin commented 5 years ago

@tvs This looks ok to me, will you give it a once-over please? It's been waiting for a while.