cloudfoundry-incubator / kubo-deployment

Contains manifests used to deploy Cloud Foundry Container Runtime
https://www.cloudfoundry.org/container-runtime/
Apache License 2.0
275 stars 114 forks source link

Update Windows workers to use 2019 stemcells #385

Closed astrieanna closed 5 years ago

astrieanna commented 5 years ago

What this PR does / why we need it:

  1. Updates windows workers to run on 2019. This updates the expected OS version of the stemcell and the value of the taint for the windows nodes. In order for this PR to pass in your CI pipeline, you'll need to adjust the job that uploads the windows stemcell to the Bosh director, to upload a 2019 stemcell.

  2. Sets runtime-request-timeout on windows. Setting this property causes some kubelet requests that don't normally have a timeout to have a timeout set. The goal is to work around some instability caused by hangs like this one.

How can this PR be verified?

On a bosh director where the only windows stemcell is 2019, deploy the cluster as usual in host-gw mode and see that it works.

Is there any change in kubo-release? Yes

Is there any change in kubo-ci? It needs to upload a 2019 stemcell.

Does this affect upgrade, or is there any migration required?

Which issue(s) this PR fixes: Kubernetes windows support will GA with official support only for 2019. Currently, CFCR only supports 1803; this PR fixes that.

Release note: (this is covered by existing "adds windows support" release note)

NONE
cfdreddbot commented 5 years ago

:white_check_mark: Hey astrieanna! The commit authors and yourself have already signed the CLA.

benmoss commented 5 years ago

Removed the overlay opsfile for now

tenczar commented 5 years ago

lgtm