search

cloudfoundry-incubator / kubo-deployment

Contains manifests used to deploy Cloud Foundry Container Runtime
https://www.cloudfoundry.org/container-runtime/
Apache License 2.0
275 stars 114 forks source link

Narrow the overly-broad replacement on Flannel's pod-network-cidr #391

Closed tvs closed 5 years ago

tvs commented 5 years ago

Prevents other ops-files affecting Flannel's properties from being used before change-cidrs.yml

What this PR does / why we need it: The replacement in change-cidrs.yml was overly-broad, replacing everything under Flannel's properties section. This prevents other ops-files that affects Flannel from being run before this one.

How can this PR be verified? Interpolate the manifest placing the change-cidrs.yml ops-file after another manifest that also affect's Flannel's properties section.

$ cat <<'EOF' >> junk.yml
---
- type: replace
  path: /instance_groups/name=worker/jobs/name=flanneld/properties?/crap?
  value: stuff

$ bosh int manifests/cfcr.yml -o junk.yml -o manifests/ops-files/change-cidrs.yml
...

Is there any change in kubo-release? No.

Is there any change in kubo-ci? No.

Does this affect upgrade, or is there any migration required? No.

Which issue(s) this PR fixes: None.

Release note: N/A.

cfdreddbot commented 5 years ago

:white_check_mark: Hey tvs! The commit authors and yourself have already signed the CLA.

lubronzhan commented 5 years ago

Close this one since we fixed in https://github.com/cloudfoundry-incubator/kubo-deployment/pull/393