search

cloudfoundry-incubator / kubo-deployment

Contains manifests used to deploy Cloud Foundry Container Runtime
https://www.cloudfoundry.org/container-runtime/
Apache License 2.0
275 stars 114 forks source link

Combine windows #410

Closed tenczar closed 5 years ago

tenczar commented 5 years ago

What this PR does / why we need it: This PR allows us to use the docker-boshrelease that has the docker-windows job. It forces the user to use the uncompiled docker-boshrelease when a user adds windows workers. This change does the same thing for the recombined kubo/kubo-windows release.

How can this PR be verified? Run it through the normal pipelines Is there any change in kubo-release? Yes. There is a change to bring the Windows jobs back into that release. Is there any change in kubo-ci? Yes. Some scripts need to be updated to support compiling the windows releases Does this affect upgrade, or is there any migration required? No Which issue(s) this PR fixes:

Release note:

This release recombines the kubo-release and kubo-release-windows. It no longer depends on kubo-release-windows. When using Windows workers the precompiled releases for docker-boshrelease and kubo-release will be replaced with the uncompiled releases.
cfdreddbot commented 5 years ago

:x: Hey tenczar!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process.

The following github user @tenczar is not covered by a CLA.

After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s).