search

cloudfoundry-incubator / kubo-deployment

Contains manifests used to deploy Cloud Foundry Container Runtime
https://www.cloudfoundry.org/container-runtime/
Apache License 2.0
275 stars 114 forks source link

Adds empty tag k8s-args to kube-scheduler #416

Closed genehynson closed 4 years ago

genehynson commented 4 years ago

Authored-by: Gene Hynson ghynson@pivotal.io Authored-by: Gavin Morgan gmorgan@pivotal.io

What this PR does / why we need it: This PR introduces the empty key for k8s-args for the kube-scheduler job to prevent unwanted null pointers at create cluster time.

The PR doesn't affect functionality. It just makes the manifest more consistent. Every kube job should have k8s-args key.

How can this PR be verified? See that a bosh deployment with this manifest is successful and that kube-scheduler has an empty map for k8s-args.

Is there any change in kubo-release? no

Is there any change in kubo-ci? no

Does this affect upgrade, or is there any migration required? no

Which issue(s) this PR fixes: It fixes a potential null pointer exception if consuming projects assume that k8s-args yaml key will exist for all kube jobs.

Release note:

NONE
linux-foundation-easycla[bot] commented 4 years ago

CLA Check
The committers are authorized under a signed CLA.