search

cloudfoundry / log-cache

Archived: Now bundled in https://github.com/cloudfoundry/log-cache-release
Apache License 2.0
14 stars 11 forks source link

Misleading configuration name #66

Closed poy closed 6 years ago

poy commented 6 years ago

https://github.com/cloudfoundry/log-cache/blob/fce9c70e29d2523edf11eb984d5683e853cb5a9b/cmd/group-reader/config.go#L26-L28

MaxPerSource implies that the max is per SourceID when in reality it is max per RequesterID. This means that for every requester to a group, it will have the set maximum.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/157627300

The labels on this github issue will be updated when the story is started.

toddboom commented 6 years ago

I think this feature has been deprecated and removed, so this is no longer actionable. Closing it out.