cloudinary / cloudinary_ios

Cloudinary iOS SDK
MIT License
165 stars 106 forks source link

Build fails with Cloudinary 2.2 #136

Closed dionc closed 6 years ago

dionc commented 6 years ago

I get the following build errors when trying to build an app containing cloudinary_ios with Swift 4:

Showing Recent Issues
CompileSwift normal x86_64 /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDResponsiveParams.swift
    cd /Volumes/90Seconds/ios/Pods
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift -frontend -c /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Network/NetworkRequest/CLDAsyncNetworkUploadRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/CLDBaseNetworkObject.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/Results/CLDBaseResult.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/Results/Helpers/CLDBoundingBox.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CLDBuildParamsUtils.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDCloudinary.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDCompatibility.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDConfiguration.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CLDCryptoUtils.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Uploader/Requests/CLDDefaultUploadRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/CLDDefinitions.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/RequestsParams/CLDDeleteByTokenRequestParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Requests/CLDDeleteRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Results/CLDDeleteResult.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/RequestsParams/CLDDestroyRequestParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/Results/Helpers/CLDDetection.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CLDDictionaryUtils.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Downloader/CLDDownloader.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CLDError.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Network/NetworkRequest/CLDErrorRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Requests/CLDExplicitRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/RequestsParams/CLDExplicitRequestParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Results/CLDExplicitResult.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Requests/CLDExplodeRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/RequestsParams/CLDExplodeRequestParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Results/CLDExplodeResult.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/Results/Helpers/CLDFace.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Network/NetworkRequest/CLDFetchImageRequestImpl.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CLDFileUtils.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Network/NetworkRequest/CLDGenericNetworkRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CLDImageCache.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Uploader/Preupload/CLDImagePreprocessChain.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CLDImageUtils.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/Results/Helpers/CLDInfo.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/Layers/CLDLayer.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CLDLogManager.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/CLDManagementApi.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Requests/CLDMultiRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/RequestsParams/CLDMultiRequestParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Results/CLDMultiResult.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Network/Adapter/CLDNetworkAdapter.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Network/CLDNetworkCoordinator.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Network/NetworkRequest/CLDNetworkDataRequestImpl.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Network/CLDNetworkDelegate.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Network/NetworkRequest/CLDNetworkDownloadRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Network/NetworkRequest/CLDNetworkUploadRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Uploader/Preupload/CLDPreprocessChain.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Uploader/Preupload/CLDPreprocessHelpers.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/Results/Helpers/CLDRekognitionFace.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Requests/CLDRenameRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/RequestsParams/CLDRenameRequestParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Results/CLDRenameResult.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/Requests/CLDRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/RequestParams/CLDRequestParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/RequestParams/Helpers/CLDRequestParamsHelpers.swift -primary-file /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDResponsiveParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/UIViews/CLDResponsiveViewHelper.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Requests/CLDSpriteRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/RequestsParams/CLDSpriteRequestParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Results/CLDSpriteResult.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CLDStringUtils.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/Layers/CLDSubtitlesLayer.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Requests/CLDTagRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Results/CLDTagResult.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/RequestsParams/CLDTagsRequestParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/Layers/CLDTextLayer.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Requests/CLDTextRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/RequestsParams/CLDTextRequestParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/ManagementApi/Results/CLDTextResult.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/CLDTranformation.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/UIViews/CLDUIImageView.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Uploader/CLDUploader.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Uploader/Requests/CLDUploadRequest.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Uploader/RequestParams/CLDUploadRequestParams.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Uploader/Requests/CLDUploadRequestWrapper.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Uploader/Results/CLDUploadResult.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Url/CLDUrl.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Helpers/Results/Helpers/CommonResultKeys.swift "/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CryptoKit/Data Extensions/Data+HashFunction.swift" "/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CryptoKit/Data Extensions/Data+Int.swift" "/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CryptoKit/Math Protocols/EndianRepresentable.swift" "/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CryptoKit/Math Protocols/ExpressibleByInt.swift" "/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CryptoKit/Hash Algorithms/HashAlgorithm.swift" "/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CryptoKit/Hash Algorithms/HashFunction.swift" "/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CryptoKit/Hash Algorithms/HashFunctionOptions.swift" "/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CryptoKit/Hash Algorithms/Implementations/MD5.swift" "/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CryptoKit/Hash Algorithms/MerkleDamgardConstructor.swift" "/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CryptoKit/Math Protocols/RotateOperations.swift" "/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Utils/CryptoKit/Hash Algorithms/Implementations/SHA1.swift" /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Extensions/UIButton+Cloudinary.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Extensions/UIImageView+Cloudinary.swift /Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/Features/Extensions/UIView+Cloudinary.swift -target x86_64-apple-ios8.0 -enable-objc-interop -sdk /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.2.sdk -I /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Products/Debug-iphonesimulator/Cloudinary -F /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Products/Debug-iphonesimulator/Cloudinary -F /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Products/Debug-iphonesimulator/Alamofire -application-extension -enable-testing -g -import-underlying-module -module-cache-path /Users/dion/Library/Developer/Xcode/DerivedData/ModuleCache -profile-generate -profile-coverage-mapping -swift-version 3 -enforce-exclusivity=checked -D DEBUG -D COCOAPODS -serialize-debugging-options -report-errors-to-debugger -Xcc -I/Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/swift-overrides.hmap -Xcc -iquote -Xcc /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/Cloudinary-generated-files.hmap -Xcc -I/Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/Cloudinary-own-target-headers.hmap -Xcc -I/Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/Cloudinary-all-non-framework-target-headers.hmap -Xcc -ivfsoverlay -Xcc /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/all-product-headers.yaml -Xcc -iquote -Xcc /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/Cloudinary-project-headers.hmap -Xcc -I/Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Products/Debug-iphonesimulator/Cloudinary/include -Xcc -I/Volumes/90Seconds/ios/Pods/Headers/Private -Xcc -I/Volumes/90Seconds/ios/Pods/Headers/Public -Xcc -I/Volumes/90Seconds/ios/Pods/Headers/Public/Crashlytics -Xcc -I/Volumes/90Seconds/ios/Pods/Headers/Public/Fabric -Xcc -I/Volumes/90Seconds/ios/Pods/Headers/Public/GoogleMaps -Xcc -I/Volumes/90Seconds/ios/Pods/Headers/Public/GooglePlacePicker -Xcc -I/Volumes/90Seconds/ios/Pods/Headers/Public/GooglePlaces -Xcc -I/Volumes/90Seconds/ios/Pods/Headers/Public/Intercom -Xcc -I/Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/DerivedSources/x86_64 -Xcc -I/Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/DerivedSources -Xcc -DPOD_CONFIGURATION_DEBUG=1 -Xcc -DDEBUG=1 -Xcc -DCOCOAPODS=1 -Xcc -ivfsoverlay -Xcc /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/unextended-module-overlay.yaml -Xcc -working-directory/Volumes/90Seconds/ios/Pods -emit-module-doc-path /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/Objects-normal/x86_64/CLDResponsiveParams~partial.swiftdoc -serialize-diagnostics-path /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/Objects-normal/x86_64/CLDResponsiveParams.dia -Onone -module-name Cloudinary -emit-module-path /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/Objects-normal/x86_64/CLDResponsiveParams~partial.swiftmodule -emit-dependencies-path /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/Objects-normal/x86_64/CLDResponsiveParams.d -emit-reference-dependencies-path /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/Objects-normal/x86_64/CLDResponsiveParams.swiftdeps -o /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Cloudinary.build/Objects-normal/x86_64/CLDResponsiveParams.o -index-store-path /Users/dion/Library/Developer/Xcode/DerivedData/NinetySeconds-hansmiyvxlpykrexsyyldiruvttc/Index/DataStore -index-system-modules

/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDResponsiveParams.swift:61:17: error: method 'setStepSize' with Objective-C selector 'setStepSize:' conflicts with setter for 'stepSize' with the same Objective-C selector
    public func setStepSize(_ stepSize:Int) -> Self {
                ^
/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDResponsiveParams.swift:39:18: note: setter for 'stepSize' declared here
    internal var stepSize = defaultStepSize
                 ^
/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDResponsiveParams.swift:66:17: error: method 'setMaxDimension' with Objective-C selector 'setMaxDimension:' conflicts with setter for 'maxDimension' with the same Objective-C selector
    public func setMaxDimension(_ maxDimension:Int) -> Self {
                ^
/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDResponsiveParams.swift:40:18: note: setter for 'maxDimension' declared here
    internal var maxDimension = defaultMaxDimension
                 ^
/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDResponsiveParams.swift:71:17: error: method 'setMinDimension' with Objective-C selector 'setMinDimension:' conflicts with setter for 'minDimension' with the same Objective-C selector
    public func setMinDimension(_ minDimension:Int) -> Self {
                ^
/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDResponsiveParams.swift:41:18: note: setter for 'minDimension' declared here
    internal var minDimension = defaultMinDimension
                 ^
/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDResponsiveParams.swift:76:17: error: method 'setReloadOnSizeChange' with Objective-C selector 'setReloadOnSizeChange:' conflicts with setter for 'reloadOnSizeChange' with the same Objective-C selector
    public func setReloadOnSizeChange(_ reload: Bool) -> Self {
                ^
/Volumes/90Seconds/ios/Pods/Cloudinary/Cloudinary/CLDResponsiveParams.swift:38:18: note: setter for 'reloadOnSizeChange' declared here
    internal var reloadOnSizeChange = defaultReloadOnSizeChange
                 ^
shirlymanor commented 6 years ago

Thank you for sharing the details! A fix for the issue was deployed. Can you please try and let me know if everything works okay for you now?

vtcajones commented 6 years ago

I'm still seeing this with 2.2 installed via CocoaPods today.

shirlymanor commented 6 years ago

@vtcajones Can you please try to create an empty project and see if that happens again?

vtcajones commented 6 years ago

@shirlymanor I manually specified 2.2.1 in my pod file and it installed and I no longer have the issue, thanks! I guess for some reason cocoapods was only giving me 2.2.0

shirlymanor commented 6 years ago

@vtcajones Glad to hear it's working!