Add the status code as part of the user info instead of old logic

cloudinary / cloudinary_ios

Cloudinary iOS SDK

MIT License

165 stars 106 forks source link

Add the status code as part of the user info instead of old logic #345

Closed ghost closed 2 years ago

ghost commented 2 years ago

Brief Summary of Changes

What does this PR address?

[ ] GitHub issue (Add reference - #XX)
[ ] Refactoring
[ ] New feature
[x] Bug fix
[x] Adds more tests

Are tests included?

[x] Yes
[ ] No

Reviewer, please note:

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I ran the full test suite before pushing the changes and all the tests pass.

ghost commented 2 years ago

@const-cloudinary Hi, some of the tests dont pass in my IDE, I think its a problem with the CLDConfiguration, last time i had the same issue and Jenkins did manage to build all tests, so lets take a look.

AlexPinhasov commented 2 years ago

@const-cloudinary Build Passes _test_downloadImageshouldReturnNetworkErrorCode() out put for url "https://******.cloudinary.com/image/upload/c_fill,dpr_3.0,f_heic,g_auto,h_100,q_auto,w_100/v1/some_invalid_url" is Error Domain=com.cloudinary.error Code=-7006 "(null)" UserInfo={statusCode=404} Unlike the first fix on 3.0.2 the "Code" is the same as it was before, the change i that i added the "statusCode" to the userInfo parameter of errors

I am done 👯