cloudinary / cloudinary_ios

Cloudinary iOS SDK
MIT License
165 stars 106 forks source link

Carthage support #47

Closed ale84 closed 2 years ago

ale84 commented 8 years ago

Could you include support for Carthage?

FiRiN59 commented 7 years ago

Any news on this one?

taragano commented 7 years ago

Carthage is still not supported a the moment. It's on our road-map to support it in one of our future versions, however there's no ETA for this yet.

MartinBergerDX commented 7 years ago

It would be useful to have this enhancement done.

MartinBergerDX commented 7 years ago

@taragano Are there some issues with adding Carthage support? It shouldn't take long. Maybe i can try?

SandeepAggarwal commented 7 years ago

Hey guys , pls include support for Carthage or open source the objc version of Cloudinary SDK

daveingle commented 7 years ago

@SandeepAggarwal until this issue is resolved you can use my fork of the repo. I've made the build scheme shared and switched to Carthage for the Alamofire dependency.

https://github.com/daveingle/cloudinary_ios

SandeepAggarwal commented 7 years ago

@daveingle Have u tested it whether it is running fine via carthage ? Actually I also tried but couldn't make it work

daveingle commented 7 years ago

@SandeepAggarwal Yes, it's working for me, remember you need to include the Alamofire sub-dependency. I have managed to use Cloudinary on both the simulator and the device. Admittedly I have not tried a release build.

SandeepAggarwal commented 7 years ago

@daveingle Thank you, this was much needed in my ongoing project. You saved my lot of headache. Thanks man.

SandeepAggarwal commented 7 years ago

@daveingle I am getting an error upon using the cloudinary in Carthage: _

Parse error: expected submodule commit SHA in output of task (ls-tree -z 2.0.1 Cloudinary/Frameworks/Alamofire) but encountered:

_ The cartfile looks like:

github "Alamofire/Alamofire" ~> 4.1
github "daveingle/cloudinary_ios"
daveingle commented 7 years ago

@SandeepAggarwal Carthage will use the latest tag if you don't have version info I believe. Try github "daveingle/cloudinary_ios" "master"

joel-yc commented 7 years ago

Carthage support is a must for my team. We can't use cocoapods.

+1 for adding carthage support please

runmad commented 7 years ago

Any updates on this? We cannot use Cocapods and I have little luck integrating it manually with iOS 11 + Xcode 9.

joel-yc commented 7 years ago

We ended up not using the Cloudinary lib at all. Instead, since we were already using Alamofire, we just did a direct multiform post to Cloudinary.

Alamofire.upload(multipartFormData: { multipartFormData in for (key, value) in parameters { ... }

Hope that helps...

SandeepAggarwal commented 7 years ago

hey @joel-yc , @runmad , give a try here https://github.com/SandeepAggarwal/cloudinary_ios

Just add following to your Cartfile: github "https://github.com/SandeepAggarwal/cloudinary_ios.git" "master"

runmad commented 7 years ago

@SandeepAggarwal doesn't work for me

daveingle commented 7 years ago

@runmad That was forked from my repo, I've managed to release to the store using Carthage. What doesn't work for you?

lacyrhoades commented 7 years ago

Not sure about @runmad but this is what I get. It's pretty much the same if I try to carthage update from cloudinary/cloudinary_ios

$ carthage update
*** Fetching cloudinary_ios
*** Checking out cloudinary_ios at "ae86625fa1e7ce83e0b32f70080aef9398e4ac6e"
Parse error: expected submodule commit SHA in output of task (ls-tree -z ae86625fa1e7ce83e0b32f70080aef9398e4ac6e Cloudinary/Frameworks/Alamofire) but encountered: 
daveingle commented 7 years ago

Try using carthage update --platform iOS --use-ssh

gemedet commented 6 years ago

+1

irodrigo17 commented 6 years ago

+1, this would be useful shouldn't be that hard to do

shirlymanor commented 6 years ago

I've added a request to our product team to add it to our road-map. we will update with any insights.

meandkareem commented 5 years ago

+1

davidvpe commented 5 years ago

@shirlymanor how is this progressing?

shirlymanor commented 5 years ago

@daveingle unfortunately there is no ETA yet. I've asked to higher the priority of this issue.

daveingle commented 5 years ago

@shirlymanor I think you meant to tag @davidvpe

FWIW, The amount of time this task should take is minimal. Hours not days.

Although I no longer use Cloudinary, if I was reviewing and comparing services right now, not offering support for one of the most common dependency managers in the community is a big red flag.

This issue is from 2016 and hasn't been resolved, I don't think your product team understands the impact of having a ticket like this sitting open.

shirlymanor commented 5 years ago

Thank you for your feedback, we escalating this issue now and will update here when we will hear back.

tevghenii-zz commented 5 years ago

Hi Any news on Carthage support?

eyalktCloudinary commented 5 years ago

@tevghenii Thank you for your interest in this. There aren't any news available yet, we'll post a notification in this thread on any updates available.

daveingle commented 5 years ago

I needed to integrate Cloudinary again. Since I still prefer Carthage over Cocoapods I created a new fork and made the changes needed to get it going. Ripping out the Alamofire submodule and reintegrating that too using Carthage etc.

For those who it would help, just add this to your Cartfile:

github "daveingle/cloudinary_ios" "carthage-support"

Love it if you could drop Alamofire as a nested dependency sometime.

ronen-burin commented 5 years ago

@daveingle, thank you. your suggestion will be evaluated.

meandkareem commented 5 years ago

Any updates on this one ?

ChristopherJoonMiller commented 5 years ago

I would just like to state that I am also interested in using Carthage over cocoapods. I am hoping there is an official support option implemented soon.

shirlymanor commented 4 years ago

Hey, we published a beta release that supports carthage: https://github.com/cloudinary/cloudinary_ios/releases/tag/2.9.0-beta.2 Can you please let us know any feedback?

ChechkovEugene commented 3 years ago

In Version 2.9.0 all is fine. But in version 2.10.0 there is an error on installing as Carthage dependency

Dependency "cloudinary_ios" has no shared framework schemes for any of the platforms: iOS

If you believe this to be an error, please file an issue with the maintainers at https://github.com/cloudinary/cloudinary_ios/issues/new

michalkcloudinay commented 3 years ago

Hi @ChechkovEugene, thanks for reporting this. We have opened an issue internally and we will update once this is fixed.

michalkcloudinay commented 3 years ago

Hi @ChechkovEugene, A new version for iOS SDK was released (2.10.1) with a fix for this issue. Please let us know if everything works as expected. Thanks