search

clubcapra / markhor

🐐 Capra-Markhor is a ROS-based solution for managing and operating Club Capra's second rescue robot. 🐐
9 stars 1 forks source link

Flipper ros control #21

Closed lvanasse closed 2 years ago

lvanasse commented 2 years ago

Yes it's a big PR. The main reason why there's so many files, is because the nodes requires the CTRE lib. So you can skip most of the files that are inside the include/ctre folder

lvanasse commented 2 years ago

Also, I've left TODO that are a little too big for this PR since I just want to make it into the master branch before forgetting about it. And those will be good introduction to the flipper code base.

lvanasse commented 2 years ago

And there's @saxtot PR inside it for the launch files (time constraint measure sry).

lvanasse commented 2 years ago

Yes it's a big PR. The main reason why there's so many files, is because the nodes requires the CTRE lib. So you can skip most of the files that are inside the include/ctre folder

Ok so instead I've deleted the CTR folder, so only the modified files are there and the notice that they were renamed (from markhor_base to markhor_tracks).

lvanasse commented 2 years ago

Also for markhor_flippers you can check the markhor/markhor_flippers/doc/markhor_flipper_seq_diag/markhor_flipper_control.png file which is a small sequence diagram representing what's going on

lvanasse commented 2 years ago

Since GitHub doesn't have a good UI, make sure to load all the diff on every file, so you don't skip files.

lvanasse commented 2 years ago

I've done the modification that came up last night, please still review it & add your approval. I'll do some testing next weekend to make sure everything works fine, and if so I'll merge the PR.

lvanasse commented 2 years ago

Since there's no more comment, I'll close and merge the PR.