search

clubcapra / markhor

🐐 Capra-Markhor is a ROS-based solution for managing and operating Club Capra's second rescue robot. 🐐
9 stars 1 forks source link

Tpv launch #34

Closed saxtot closed 2 years ago

saxtot commented 2 years ago

Simply adds a launch file for the TPV controller to markhor_bringup.

lvanasse commented 2 years ago

Ah maybe, do you want to add in the README a new bullet point for this dependency? Like we did for the e-sport and such.

saxtot commented 2 years ago

Ah maybe, do you want to add in the README a new bullet point for this dependency? Like we did for the e-sport and such.

Correct me if I'm wrong, but wouldn't a dependency be absolutely required for the package to work? For example, the launch files include most of the multiplicators, however, the robot still launches as the nodes simply fail or don't work. So, we never considered Markhor dependent to them. Likewise, in the meager amount of tests I ran, the node working wasn't necessary for the rest of the ROS environment.

lvanasse commented 2 years ago

Well, in that case, if we launch the markhor_base.launch launch file without the microcontroller node it will likely produce error, although it might not fail.

It kind of the same situation as for this PR that Myriam did a while back : https://github.com/clubcapra/markhor/pull/24

And you're right, maybe dependency is not the right term. Although, my intention is to be clear about what needs to be present in the workspace for the launch file to work without error. I'm open to ideas if you have a way to accomplish this without too much trouble.

saxtot commented 2 years ago

What would you think of a simple "if" statement in the launch file? Where if the package is not found, it is printed once in the console without it necessarily being an error.

benmalenfant commented 2 years ago

Looking good!👍🏻

lvanasse commented 2 years ago

What would you think of a simple "if" statement in the launch file? Where if the package is not found, it is printed once in the console without it necessarily being an error.

Humm I think I prefer an error. But that's alright if you want to do it this way.

saxtot commented 2 years ago

I think I understand what you mean then. We could leave the code as is and add a section in the README with the packages that are expected to be present upon normal use, but aren't entirely necessary to launch markhor.

lvanasse commented 2 years ago

I think I understand what you mean then. We could leave the code as is and add a section in the README with the packages that are expected to be present upon normal use, but aren't entirely necessary to launch markhor.

Yup, I think that would be more clear 👍