search

clubcapra / markhor

🐐 Capra-Markhor is a ROS-based solution for managing and operating Club Capra's second rescue robot. 🐐
9 stars 1 forks source link

Fix markhor_w_attachments #40

Closed benmalenfant closed 1 year ago

benmalenfant commented 1 year ago

The file was broken since markhor URDF had changed, needed to redeclare the link between the base and the arm, lidar no longer needed since it was integrated to the markhor.urdf.xacro file

*also includes fixes to the gazebo launch files

Here is a proof this runs in RViz image

lvanasse commented 1 year ago

The file was broken since markhor URDF had changed, needed to redeclare the link between the base and the arm, lidar no longer needed since it was integrated to the markhor.urdf.xacro file

*also includes fixes to the gazebo launch files

Here is a proof this runs in RViz image

Can you run it in Gazebo also?

benmalenfant commented 1 year ago

image well does that count XD

lvanasse commented 1 year ago

image well does that count XD

Well if that's the first thing the user of the simulation see, I'd say no, sadly.

benmalenfant commented 1 year ago

image Yeah, gazebo sim needs to be fixed, but this is outside the scope of this PR, it is already not working due to namespace changes, I'm working on another PR to fix that

lvanasse commented 1 year ago

image Yeah, gazebo sim needs to be fixed, but this is outside the scope of this PR, it is already not working due to namespace changes, I'm working on another PR to fix that

Ok, and this PR is to fix the attachment, so the link between Markhor and Ovis? Would is there a reason to split the two PR?

benmalenfant commented 1 year ago

This PR fixes RVIZ, we can now publish to the joint_states with values in rads to see the current robot state

lvanasse commented 1 year ago

This PR fixes RVIZ, we can now publish to the joint_states with values in rads to see the current robot state

Ah, that wasn't clear to me.