search

clubcapra / markhor

🐐 Capra-Markhor is a ROS-based solution for managing and operating Club Capra's second rescue robot. 🐐
9 stars 1 forks source link

Fix flippers node and allow all flippers to be controlled at once #45

Closed GLDuval closed 1 year ago

GLDuval commented 2 years ago

A few lines were causing issues on the master branch, removing some code fixed the issue. The flipper services were also changed to allow all 4 flippers to be activated at once by calling the services.

benmalenfant commented 2 years ago

Some of the lines removed were commited by me to avoid edge cases runaways, we need to look into those if we revert them

benmalenfant commented 2 years ago

Could we setup a meeting tomorow(today) to discuss these changes?

GLDuval commented 2 years ago

Could we setup a meeting tomorow(today) to discuss these changes?

I'm a bit busy this weekend but we can meet next friday if you're there

GLDuval commented 2 years ago

What bug does this fixes, what testing has been done?

The curent changes on master cause the flipper node to die on launch, after trying to isolate and fix the issue a lot of weird behaviors occurred. But when I was using the code we used during the robocup all the issues were gone. So the changes are what we had during Robocup.