search

clubcapra / markhor

🐐 Capra-Markhor is a ROS-based solution for managing and operating Club Capra's second rescue robot. 🐐
9 stars 1 forks source link

Flipper joint state #46

Closed benmalenfant closed 1 year ago

benmalenfant commented 1 year ago

This PR includes publishing the flippers joint states so it can be visualised in RVIZ, it also fixes the front flipper inversion due to the mechanical changes

GLDuval commented 1 year ago

This PR includes publishing the flippers joint states so it can be visualised in RVIZ, it also fixes the front flipper inversion due to the mechanical changes

Oh was there a mechanical change? Also is the front left flipper fixed or is it still acting weird like yesterday?

GLDuval commented 1 year ago

This PR includes publishing the flippers joint states so it can be visualised in RVIZ, it also fixes the front flipper inversion due to the mechanical changes

Oh was there a mechanical change? Also is the front left flipper fixed or is it still acting weird like yesterday?

Nvm I just saw your post in teams thank you for the fix!

benmalenfant commented 1 year ago

The flippers were reversed by the mechanical team to increase ground clearance and help with the oil leaks issue

saxtot commented 1 year ago

Could you clarify the state of this review? It's a draft with only two reviewers. Is it full PR ready for you?

benmalenfant commented 1 year ago

Could you clarify the state of this review? It's a draft with only two reviewers. Is it full PR ready for you?

I wanted to get initial review and impression before I make it a real PR and poke everyone with it.

lvanasse commented 1 year ago

I won't approve, but I think this PR is fine from what I can see. :)

benmalenfant commented 1 year ago

@saxtot @GLDuval could you aprove this request please