clubcapra / markhor

🐐 Capra-Markhor is a ROS-based solution for managing and operating Club Capra's second rescue robot. 🐐
9 stars 1 forks source link

Tweak allowable_closedloop_error value #52

Closed GLDuval closed 1 year ago

GLDuval commented 1 year ago

This PR fixes the issue where the tracks would still move after the tracks stopped receiving an input.

benmalenfant commented 1 year ago

This is not the right fix, this will allow the tracks to freely spin when no command is sent, the core issue here is the I parameter of the PID being too large, we could limit it further and/or lower the gain but for the momment, I simplified the system to just use a P controller, we need to tune the PID right in order to fix it properly

benmalenfant commented 1 year ago

Seems like i forgot to commit my tracks.launch... I'll add it to my branch and we can merge the odometry pr