search

cmoog / vscode-sql-notebook

Open SQL files as VSCode Notebooks.
https://marketplace.visualstudio.com/items?itemName=cmoog.sqlnotebook
MIT License
120 stars 16 forks source link

add query timeout configuration option #27

Closed cmoog closed 2 years ago

cmoog commented 2 years ago

Closes #26

RollsChris commented 2 years ago

Hi.. is there a reason why this was not applied to the other drivers?

cmoog commented 2 years ago

@RedEyedDog The query timeout is passed through to all three drivers currently supported: mysql, postgres, and mssql.

The relevant code snippets: https://github.com/cmoog/vscode-sql-notebook/blob/0253d2f21d82da2df3ade241c0932df32354364e/src/driver.ts#L106 https://github.com/cmoog/vscode-sql-notebook/blob/0253d2f21d82da2df3ade241c0932df32354364e/src/driver.ts#L150 https://github.com/cmoog/vscode-sql-notebook/blob/0253d2f21d82da2df3ade241c0932df32354364e/src/driver.ts#L209

At the moment, none of the driver behavior is covered by automated tests, so please do open an issue if something isn't working as expected.

RollsChris commented 2 years ago

hey thanks, i didn't notice the others ;) do you know when this will be release its bugging me

cmoog commented 2 years ago

@RedEyedDog v0.5.0 is live!

RollsChris commented 2 years ago

@cmoog owww yes.. thanks :)

RollsChris commented 2 years ago

i can confirm this is working very nice for mssql