search

cms-L1TK / firmware-hls

HLS implementation of the tracklet pattern reco modules of the Hybrid tracking chain
15 stars 24 forks source link

New binned memory for full combined module projects/ IR->TP split-FPGA chain #315

Closed jasonfan393 closed 7 months ago

jasonfan393 commented 8 months ago

includes new binned memory module for full projects including disks. Also includes an IR->TP chain representative of the first half of the TF algo for a split FPGA project.

Draft PR to test how this reacts with CI

correspnds to project_generation_scripts 57

update: marked as ready for review. IR->TP chain mostly works in simulations, with some bugs related to wiring.

aehart commented 7 months ago

@jasonfan393 In addition to my inline comments, I think the modules in tf_mem_format.vhd could be generalized into a single module with generics and arrays. What you have is fine for now, but I'd like to clean it up in the near future.

aehart commented 7 months ago

Also, since https://github.com/cms-L1TK/project_generation_scripts/pull/57 was merged, please update the submodule here to point to the head of the master branch.

jasonfan393 commented 7 months ago

@jasonfan393 In addition to my inline comments, I think the modules in tf_mem_format.vhd could be generalized into a single module with generics and arrays. What you have is fine for now, but I'd like to clean it up in the near future.

Ok, I agree this can be cleaned up, we can open this as an issue so we can keep track of this.