search

cmsdaq / DAQExpert

New expert system processing data model produced by DAQAggregator
1 stars 2 forks source link

ContinouslySoftError should apply counts per subsystems #175

Closed andreh12 closed 6 years ago

andreh12 commented 6 years ago

To avoid producing error messages with subsystems with multiple fixing soft error occurrences coinciding in time (e.g. 5 minutes apart) but within the threshold window (10 minutes currently) class ContinouslySoftError should count and apply thresholds to the fixing soft error cycles per subsystem rather than globally.

If multiple subsystems reach the threshold independently, the error message should still include all such subsystems.

A test case is here: http://cmsrc-srv.cms:9500/RunInfoTimeline/?sessionId=301649&timezone=local&window=02:00:00.0&maxWindow=06:00:00.0

andreh12 commented 6 years ago

in fact, counting per subsystem was added in c8cd953 but the logic to produce the error message does not apply the minimum threshold.

andreh12 commented 6 years ago

merged from branch hotfix/per-subsystem-repeated-softerror-recovery-message into master ( 7f78c27 ) and dev ( 8cedb66 ).