search

cmsdaq / DAQExpert

New expert system processing data model produced by DAQAggregator
1 stars 2 forks source link

add support for a separate threshold during machine development in module CloudFuNumber #226

Closed andreh12 closed 6 years ago

andreh12 commented 6 years ago

as suggested by @geneguvo

gladky commented 6 years ago

With this hotfix I propose to change the title of the condition from camel case to sth more human readable.

screen shot 2018-06-12 at 11 02 10

Just update this:

this.name = "CloudFUnumber";

andreh12 commented 6 years ago

can we have spaces in the name ? If so I would propose Cloud FU number. Or # cloud FUs ? or number of cloud FUs ?

gladky commented 6 years ago

Yes we can. This field is used in the names of conditions in the browser and in the dashboard. You can see most of them are with spaces. I would personally go for

Too many FUs in cloud mode

as it tells you what's the problem.

andreh12 commented 6 years ago

ok, changed in 76450a1

andreh12 commented 6 years ago

earlier tickets about this module: #131 (initial proposal for the module) and #163 (holdoff timer behaviour modification)

andreh12 commented 6 years ago

The commits above do not introduce a second separable threshold but instead treat MD/TS periods like we have been treating interfill periods far away from stable beams so far (effectively no limit on the fraction of cloud FUs).

andreh12 commented 6 years ago

released in https://github.com/cmsdaq/DAQExpert/releases/tag/2.10.16

andreh12 commented 6 years ago

forgot to add that mvn test on master (88cc5f0) reports: Tests run: 186, Failures: 0, Errors: 0, Skipped: 21

and mvn integration test reports Tests run: 13, Failures: 0, Errors: 0, Skipped: 2.