cmsdaq / DAQExpert

New expert system processing data model produced by DAQAggregator
1 stars 2 forks source link

add holdoff for deadtime module #95

Open andreh12 opened 7 years ago

andreh12 commented 7 years ago

recently there were many occurrences of dead time but for short periods.

It was proposed that we modify the deadtime detection to add some 'holdoff' time (similar to what the Transition module does), i.e. only fire the deadtime condition if the deadtime is above threshold for a certain minimum time or number of snapshots.

We probably should first look at the distribution of the lengths in time of the deadtime occurrences before agreeing on a value.

The value should be configurable like other parameters.

Requiring a minimum time (as opposed to requiring a minimum number of snapshots above threshold) has the advantage that the behavior should be very similar in the dev instance where the snapshot frequency may be different.

For accounting purposes we still may want to have the same module indicating dead time (so that we can see it in the browser time line) have a second module which then after some delay indicates the condition to the shifter.

Alternatively, we could still show the deadtime condition to the shifter without any delay but have another module which causes the sound alert.