cmu-delphi / epiprocess

Tools for basic signal processing in epidemiology
https://cmu-delphi.github.io/epiprocess/
Other
13 stars 8 forks source link

[perf]: address regressions in slide_improvements #526

Open dshemetov opened 1 month ago

dshemetov commented 1 month ago

Perf has 3-4x slowdown due to validate_tibble and as_environment in as_slide_computation. To address later.

See here.

brookslogan commented 1 month ago

Note that this slowdown is for tidyeval [epi_slide] only. I believe Dmitry found a speedup for at least formulas [on epi_slide, and no perf regression for epix_slide?].