Integrate datamodules - Githubissues

cnellington / Contextualized

An SKLearn-style toolbox for estimating and analyzing models, distributions, and functions with context-specific parameters.

http://contextualized.ml/

GNU General Public License v3.0

65 stars 9 forks source link

Integrate datamodules #141

Closed wtt102 closed 1 year ago

wtt102 commented 1 year ago

Completed

Regression now using map style datasets
Single datamodule in datamodules.py that gets instantiated within each regression lightning module
All unit tests run expect for markov (not converging); currently troubleshooting this.
Same results + speed between dataloader and datamodule methods

In progress / needed

Fix markov not converging
Get notmad to also instantiate its own datamodule (should be straightforward, and this looks pretty accessible given the current state I'm seeing)
Possibly abstract or move datamodules from notmad and regression to a single file (thinking keeping these separate may be less confusing)
Proofread documentation

cnellington commented 1 year ago

Closing because this code exists in a new branch now #177.