search

cnellington / Contextualized

An SKLearn-style toolbox for estimating and analyzing models, distributions, and functions with context-specific parameters.
http://contextualized.ml/
GNU General Public License v3.0
65 stars 9 forks source link

Benefits of Contextualized ML notebook #213

Closed AndreaRubbi closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

cnellington commented on 2023-09-06T02:18:25Z ----------------------------------------------------------------

I recently learned that lightning logs at a different level and isn't silenced by %%capture, use this as well during import:

import logging

logging.getLogger("pytorch_lightning").setLevel(logging.ERROR)


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

cnellington commented on 2023-09-06T02:18:26Z ----------------------------------------------------------------

Can we display these as subplots in a single row for readability?


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

cnellington commented on 2023-09-06T02:18:27Z ----------------------------------------------------------------

These figures take up a lot of space, could they be made into 2-column subplots instead?


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

cnellington commented on 2023-09-06T02:18:27Z ----------------------------------------------------------------

Index is never used in the exposition. What does it mean?


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

cnellington commented on 2023-09-06T02:18:28Z ----------------------------------------------------------------

Seems like we're using this plot format a lot, can we clean up some duplicated code to improve readability?


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

cnellington commented on 2023-09-06T02:18:29Z ----------------------------------------------------------------

Can we also clean up duplicated code for these plots


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

cnellington commented on 2023-09-06T02:18:30Z ----------------------------------------------------------------

This is a very very nice plot!


  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.