search

cnr-ibf-pa / hbp-bsp-issues

Ticketing system for developers/testers and power users of the Brain Simulation Platform of the Human Brain Project
4 stars 0 forks source link

E-models appearing on Single Cell category in Model Catalog #423

Closed antonelepfl closed 5 years ago

antonelepfl commented 5 years ago

Hi @rmiglior, I see that there are now a couple of E-Models appearing on the Single Cell category As you can see here:

Screenshot 2019-03-28 at 10 54 38

The issue that before I had under that category the result of the optimization (with their Morphology and a representative trace plot) but now these E-Models don't have any of that information (at least attached) and the optimization for that E-Model is already on the list.

Could we create another category or let me know the way I can distinguish between the E-Models and the Optimizations? Mainly because if we have the same category in the BSP we will get a list of Models that may look like:

Screenshot 2019-03-28 at 10 59 19

And I don't think is what the user will expect to see.

clupascu commented 5 years ago

Hi @antonelepfl, where do you fetch the E-Models from?

antonelepfl commented 5 years ago

I just fetch the list of Single Cells and the e-models are there

clupascu commented 5 years ago

Where do you fetch from the list of Single Cells?

appukuttan-shailesh commented 5 years ago

@antonelepfl , @clupascu : These were created by me, as part of the process of running the validation on the BluePyMM output models (as discussed on Hippocampus VC recently).

These entries would all be migrated to the KG soon (coming weeks?). The KG has finer resolution to distinguish between the kinds of models (E-model vs ME-model). Before this migration happens, we needed a temporary way to identify the entries corresponding to E-models and thus their naming with prefix emodel-. I imagine it would be possible for you to filter out these entries (using the prefix) and continue as before with the remaining entries.

appukuttan-shailesh commented 5 years ago

Also, can you let me know the filters you are currently using to identify the "optimizations"?

antonelepfl commented 5 years ago

Before for the Hippocampus Models I was just doing https://validation-v1.brainsimulation.eu/models/?brain_region=hippocampus&organization=HBP-SP6&model_scope=single%20cell&species=Rattus%20norvegicus

clupascu commented 5 years ago

@antonelepfl But essentially I think you should list only optimizations. Maybe the E-Models are used for other use cases, but not for the Single Cell Building. As you are saying the optimizations for those E-Models are already on the list anyway.

antonelepfl commented 5 years ago

I know that I can iterate thru the entire list of models and select those which are optimizations. My point is that I would like to use Model Catalog to find specifically what I want and not to pull most of the models to then iterate manually. As Shailesh mentioned those e-models will be categorized better when the full integration with the KG is done. Just @appukuttan-shailesh keep me updated.

appukuttan-shailesh commented 5 years ago

Resolved as part of temporary fix for #437 It can be closed after @antonelepfl confirms this is no longer an issue.

antonelepfl commented 5 years ago

You can close this now