search

cnr-ibf-pa / hbp-bsp-issues

Ticketing system for developers/testers and power users of the Brain Simulation Platform of the Human Brain Project
4 stars 0 forks source link

Model Validation app uses KnowledgeGraph as database backend #425

Closed apdavison closed 4 years ago

apdavison commented 5 years ago

Update use case

Use Case Update

Aspect Detail
Summary Adapt the Model Validation app on the Brain Simulation Platform to use the Knowledge Graph as its database backend.
Expert @apdavison
Deadline end of April 2019
Dependencies #380

List of additional/changed features

Tasks

Acceptance Criteria

apdavison commented 5 years ago

Due to pressure from reviewers to make models available through Knowledge Graph search, we changed the order of work items, and have performed a migration of model catalog data to the production KG. This has delayed testing of the reimplementation of the REST API, which is now ongoing. New deadline for full deployment to production end of June 2019.

apdavison commented 5 years ago

Update:

appukuttan-shailesh commented 5 years ago

Knowledge Graph Search https://collab.humanbrainproject.eu/#/collab/47/nav/86751

appukuttan-shailesh commented 5 years ago

@clupascu : Existing REST API: https://hbp-validation-framework-api.readthedocs.io Python Client: https://hbp-validation-client.readthedocs.io

alex4200 commented 5 years ago

@appukuttan-shailesh

When I use the Knowledge Graph Search and I search for the keyword 'cerebellum' I find 5 models. When I then click on Data download: download all related data as ZIP a new tab opens with an error Oops, an error occurred This exception has been logged with id 7ca9efhig.

Also, when I open a different model (e.g. search for 'hippocampus') I do not see a download link, but a link 'Go to the data'.

Why does this happen? Are these bugs, or is something still missing?

appukuttan-shailesh commented 5 years ago

@alex4200 : I won't be the right person to answer KG related queries (at least, not yet :p). Maybe better to redirect these to @apdavison for the time being.

Regarding the "Go to the data" bit.... this must be because the model owner decided to provide a URL to Github repository containing the model (instead of a directly downloadable file URL) and your are therefore being redirected to this repository.

@apdavison : in the case of github URLs we should enforce that they point to a specific commit ID (or similar) to ensure that the model instance does not change with new commits to the repository.

apdavison commented 5 years ago

@alex4200 we should perhaps move this discussion to a new ticket, since your question is about the KG Search and not about the Model Validation app.

The "download as ZIP" error is indeed a bug, thanks for alerting us to this. @appukuttan-shailesh is correct that the "Go to the data" link appears when the model is on Github or ModelDB, rather than in CSCS storage.

@appukuttan-shailesh I see your point. The model instance does contain the commit ID (as the "version" attribute"), but the user could be misled if they look at the code in "master" rather than at the specific commit.

alex4200 commented 4 years ago

@apdavison @appukuttan-shailesh The download issue seems to be solved.

appukuttan-shailesh commented 4 years ago

Final task expected to be completed by end-Nov.

alex4200 commented 4 years ago

Andrew will move the KG-based apps from staging to production in first week on January.

apdavison commented 4 years ago

Done