cnr-ibf-pa / hbp-bsp-issues

Ticketing system for developers/testers and power users of the Brain Simulation Platform of the Human Brain Project
4 stars 0 forks source link

Python3 update for Synaptic Events Fitting usecases #519

Closed alex4200 closed 4 years ago

alex4200 commented 4 years ago

Expected behavior

Should work for python3

Actual Behavior (please include screenshot if possible)

Several incompatibility issues.

Steps to reproduce the problem

  1. Clone notebook
  2. Change kernel
  3. Run all cells

The following notebooks are affected:

Optional infrastructural data (user, platform, browser, environment, ...)

Guidelines

When updating the notebook you might consider some of the Guidelines to provide an improved look & feel.

clupascu commented 4 years ago

The first version of Python 3 compatible Synaptic events fitting usecases are available for test at https://collab.humanbrainproject.eu/#/collab/71255/nav/483240 are now compatible with Python 3.

@alex4200 can you please continue to test if everything works fine and add comments here?

alex4200 commented 4 years ago

@clupascu In the very big code cell you need to import the packages first, then define the RadioButton. When I fix that manually, the notebook seems to work (at least for Jureca).

clupascu commented 4 years ago

@alex4200 What packages should I import first? This ones

import plotly import os ?

alex4200 commented 4 years ago

@clupascu Here is a part of your code:

RB1=RadioButtons(description= 'Select mod file', options=['default','local'])
display(RB1)
DM=Text()
DM.value='ProbGABAAB_EMS_GEPH_g.mod'
DM.visible=True
DM.disabled=True
display(DM)
import warnings
warnings.filterwarnings('ignore')           
from ipywidgets import widgets
from IPython.display import *
from ipywidgets import *
import requests
import json
import time
import _thread
import sys
from IPython.display import HTML,Javascript, display
...

You are trying to use an instance of RadioButtons before you import its definition.

clupascu commented 4 years ago

I fixed this. Can you please test again? Thanks.

alex4200 commented 4 years ago

@clupascu Yes this works now.

But I think you have to remove the first two cells in your DEV notebook, as these cells are being added later automatically.

clupascu commented 4 years ago

The new DEV notebooks are here

Synaptic Events Fitting https://collab.humanbrainproject.eu/#/collab/9130/nav/528639 Synaptic Events Fitting with user data https://collab.humanbrainproject.eu/#/collab/9130/nav/528640 Synaptic Events Fitting with user model https://collab.humanbrainproject.eu/#/collab/9130/nav/528641 Synaptic Events Fitting Analysis https://collab.humanbrainproject.eu/#/collab/9130/nav/529488 @alex4200 please let me know when I should modify the usecases.json with the new links to the Python3 versions.

alex4200 commented 4 years ago

@clupascu Still working on these use cases

clupascu commented 4 years ago

@alex4200 Synaptic Events Fitting use case is ready with the new modules on the HPC systems and ipywidgets 7.5.1. The links are the one from the usecases.json. Please test and let me know. Thanks.

clupascu commented 4 years ago

@alex4200 Synpatic Events Fitting - user data and user model usecases are also ready with the new modules on the HPC systems and ipywidgets 7.5.1. I updated also Synaptic Events Fitting as I introduced also Galileo. I modified also the names of the folders when they are saved to the storage. The links are the one from the usecases.json. Please test everything and let me know. Thanks.

alex4200 commented 4 years ago

@alex4200 Put into prod when all if fine @clupascu Update documentation and figures

alex4200 commented 4 years ago

Pull request for Production done: https://github.com/antonelepfl/usecases/pull/346

clupascu commented 4 years ago

I updated the documentation and figures in the Guidebook. @alex4200 please take a look and let me know when we can close this issue. Thanks.

alex4200 commented 4 years ago

@clupascu Where to find the updates; I assume you mean the dev version of the guidebook?

clupascu commented 4 years ago

Yes. Here's the link for the simple use case: https://lbologna.github.io/hbp-sp6-guidebook/online_usecases/trace_analysis/syn_events_fit/syn_events_fit.html . I updated also the other usecases of course.

alex4200 commented 4 years ago

@clupascu The pages look good to me, can be put to PROD.

alex4200 commented 4 years ago

Notebooks are up-to-date, documentation is updated. Closing ticket.