coavins / mhrise-coavins-dps

A detailed DPS meter for Monster Hunter Rise (PC)
GNU General Public License v3.0
24 stars 11 forks source link

Ailment damage is not tracked when a networked player lands the triggering attack #21

Closed coavins closed 2 years ago

coavins commented 2 years ago

Describe the bug Currently, if multiple players contribute to the buildup of an ailment and YOU are the one who triggers its effect, credit will be shared among all players proportional to their contribution to its buildup.

If a networked player is the one who triggers its effect, the damage will not appear regardless of who contributed to its buildup.

Steps to Reproduce For example:

  1. Enter a quest with more than one player using blast or poison
  2. Watch both players contribute to its buildup
  3. Allow networked player to trigger its effect, see no damage added to the table for that condition

Expected behavior Damage for ailments should be added to the table even if a networked player triggers it.

Additional context The script is just looking through the condition data on the enemy object during the update method. The information about afflicted ailments must be coming through on some other function when it is triggered by a networked player. Find that function.

coavins commented 2 years ago

I saw poison damage being credited to another player using sword and shield, so I'm not totally sure what's working here and what's not.