search

coavins / mhrise-coavins-dps

A detailed DPS meter for Monster Hunter Rise (PC)
GNU General Public License v3.0
24 stars 11 forks source link

Hunting Horn Silkbind Shockwave not counted #33

Closed SeppNel closed 2 years ago

SeppNel commented 2 years ago

Describe the bug When playing with Hunting Horn and using the new Silkbind Shockwave skill, damage is not counted for networked players (locally it works fine). The results is that the damage numbers for that player desync the more the quest goes on.

Steps to Reproduce

  1. Use Hunting Horn with Silkbind Shockwave
  2. Enter quest
  3. Use Silkbind Shockwave and attack the monster (preferably with Magnificent Trio) during the quest
  4. Compare damage numbers of local and network players

Expected behavior Damage numbers similar for local and network players

coavins commented 2 years ago

Unfortunately I don't think I'm far enough in the game yet to unlock this switch skill. I will try to take a look at this when I get the chance. I'm not familiar with how this move works, but it sounds like it might be handled similar to an ailment internally, which would mean it's probably the same issue described in #21.

coavins commented 2 years ago

It is possible this was fixed by 5f2b3ca09fb74456524f6686fc31a1bcae9d3b69, this issue should be re-tested with the latest version.

SeppNel commented 2 years ago

Sadly it's not fixed. This are the damages done after quest with lastest version (2.11.1). Local player (Me using Hunting Horn): local

Network player: network

This is with a low rank monster, you can expect it to desync even more with monsters with more HP.

coavins commented 2 years ago

Well, thanks for double checking it. I'll have to wait until I get far enough to unlock this move before I can look into it.

coavins commented 2 years ago

This issue is probably related to #46. If damage is being captured accurately through afterCalcDamage_DamageSide locally but not remotely, then this is almost certainly a new problem that didn't exist before Sunbreak. I had always seen before that all players' damage had gone through this method. There must be some new technique that needs to be discovered here.

coavins commented 2 years ago

I'm going to close this as a duplicate of #47 just to clean up the issue list a bit