Closed coavins closed 2 years ago
It also happens when using the weak% column, maybee it's be related:
[15616] sol: runtime error: ...nterRise\reframework\autorun/mhrise-coavins-dps\draw.lua:185: attempt to perform arithmetic on a nil value (field 'pctDnCrit')
[15616] stack traceback:
[15616] ...nterRise\reframework\autorun/mhrise-coavins-dps\draw.lua:185: in function 'mhrise-coavins-dps.draw.drawReportItemColumn'
[15616] ...nterRise\reframework\autorun/mhrise-coavins-dps\draw.lua:324: in function 'mhrise-coavins-dps.draw.drawReportItem'
[15616] ...nterRise\reframework\autorun/mhrise-coavins-dps\draw.lua:501: in function 'mhrise-coavins-dps.draw.drawReport'
[15616] ...nterRise\reframework\autorun/mhrise-coavins-dps\draw.lua:629: in function 'mhrise-coavins-dps.draw.dpsDraw'
It looks like this happens to me when enabling the "Not shown" row in combination with the Follow Me mod. The hits of the followers are not counted, which could lead to a division by zero:
Somehow, the value assigned is nil (instead of indef) and the draw.lua cant format the number:
Thanks for the help, I've fixed this issue from a couple different angles. This specific nan operation on draw.lua line 183 & 185 is fixed, and I also added a pcall so that any future problems of this kind should not prevent the entire table from updating.
Describe the bug The crit % column causes the display to stop updating after a monster is mounted. Probably a divide by zero or something like that is happening.
Steps to Reproduce For example:
Expected behavior Table should never stop updating, it makes it look like the mod has frozen.