search

coavins / mhrise-coavins-dps

A detailed DPS meter for Monster Hunter Rise (PC)
GNU General Public License v3.0
24 stars 11 forks source link

Add Otomo damages in total damages #8

Closed tmarti2 closed 2 years ago

tmarti2 commented 2 years ago

Hey, the commit 95a8df0ad29688ac007bae2d77615881a0cbd973 seems to contain a bug where Partner damages are displayed out of the normal bar size : bug

The line 858 might be the issue here ? : https://github.com/coavins/mhrise-coavins-dps/blob/95a8df0ad29688ac007bae2d77615881a0cbd973/mhrise-coavins-dps.lua#L858

Changing it to

item.total = item.total + item.totalOtomo;

Seems to fix this (at least visually, it works :3)

coavins commented 2 years ago

Hey, thanks for taking a look at this. I think you're close here, but this might still be wrong when multiple monsters are in the report.

In reviewing that function I see we are not resetting the totalOtomo count at the top with the others.

https://github.com/coavins/mhrise-coavins-dps/blob/95a8df0ad29688ac007bae2d77615881a0cbd973/mhrise-coavins-dps.lua#L844-L850

All of the totals need to be reset here instead of being carried over from before. Can you try adding this line there instead of changing the tally inside the loop and see if that fixes it?

item.totalOtomo = 0.0;
tmarti2 commented 2 years ago

Seems to work (it looks good)

coavins commented 2 years ago

Thank you! I will go ahead and post a new release for this.