Currently, all attacker types are merged into the report items regardless of which types are filtered. The filtering is done later when calculating the report item totals, which means it's not applying to the displayed hit count and biggest hit.
The hit count and max hit information should be stored in the damage counter along with the damage numbers themselves so that they can be merged properly in mergeReportItemCounters(). This function should also be where the filtering on attacker types is moved to from calculateTotalsForReportItem(). This would allow these two values on the table to correctly reflect the chosen filters.
Currently, all attacker types are merged into the report items regardless of which types are filtered. The filtering is done later when calculating the report item totals, which means it's not applying to the displayed hit count and biggest hit.
The hit count and max hit information should be stored in the damage counter along with the damage numbers themselves so that they can be merged properly in
mergeReportItemCounters()
. This function should also be where the filtering on attacker types is moved to fromcalculateTotalsForReportItem()
. This would allow these two values on the table to correctly reflect the chosen filters.