issues
search
code-423n4
/
2021-09-bvecvx-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
add zero address validation in constructor and initializer
#61
code423n4
opened
2 years ago
1
lack of emission of events while setting fees
#60
code423n4
opened
2 years ago
2
state variable that are not changed throughout the contract should be declared as constant
#59
code423n4
opened
2 years ago
1
use of floating pragma
#58
code423n4
opened
2 years ago
2
Missing slippage/min-return check in `veCVXStrategy`
#57
code423n4
opened
2 years ago
2
Missing slippage/min-return check in `StrategyCvxHelper`
#56
code423n4
opened
2 years ago
2
Missing slippage/min-return check in `BaseStrategy`
#55
code423n4
opened
2 years ago
2
Unbounded iteration in `CvxLocker.updateReward`
#54
code423n4
opened
2 years ago
0
`CvxLocker.findEpochId` stops after 128 iterations
#53
code423n4
opened
2 years ago
0
`CvxLocker.setApprovals` can be called by anyone
#52
code423n4
opened
2 years ago
0
`CvxLocker.setBoost` wrong validation
#51
code423n4
opened
2 years ago
3
`CvxLocker.setStakeLimits` missing validation
#50
code423n4
opened
2 years ago
1
`SettV3.transferFrom` block lock can be circumvented
#49
code423n4
opened
2 years ago
1
`SettV3._withdraw` sometimes burns too many shares
#48
code423n4
closed
2 years ago
2
`veCVXStrategy.manualRebalance` has wrong logic
#47
code423n4
opened
2 years ago
3
`veCVXStrategy._withdrawSome` reverts
#46
code423n4
closed
2 years ago
2
Gas: `_onlyNotProtectedTokens` should use maps
#45
code423n4
opened
2 years ago
1
Unused event `veCVXStrategy.TreeDistribution`
#44
code423n4
opened
2 years ago
2
Unused event `veCVXStrategy.Debug`
#43
code423n4
opened
2 years ago
3
Unused event `StrategyCvxHelper.TendState`
#42
code423n4
opened
2 years ago
2
Unused event `StrategyCvxHelper.HarvestState`
#41
code423n4
opened
2 years ago
2
Arithmetic Error - `manualRebalance` function has multiple arithmetic bugs
#40
code423n4
closed
2 years ago
3
veCVXStrategy: Unused return outputs from _processRewardsFees()
#39
code423n4
opened
2 years ago
1
veCVXStrategy: Sub-optimal trading path
#38
code423n4
opened
2 years ago
1
veCVXStrategy: Redundancies
#37
code423n4
opened
2 years ago
1
veCVXStrategy: Extra functions can be external instead of public
#36
code423n4
opened
2 years ago
1
veCVXStrategy: Erroneous Comments
#35
code423n4
opened
2 years ago
1
Swap conversion is susceptible to MEV flashbots
#34
code423n4
opened
2 years ago
1
StrategyCvxHelper: safeApprove instead of approve
#33
code423n4
opened
2 years ago
2
StrategyCvxHelper: Redundant re-initialisation of path array
#32
code423n4
opened
2 years ago
0
Delete function setKeepReward
#31
code423n4
opened
2 years ago
1
Calculation of valueInLocker
#30
code423n4
opened
2 years ago
0
public functions that can be external
#29
code423n4
opened
2 years ago
1
lpComponent is useless
#28
code423n4
opened
2 years ago
1
tend() can be simplified
#27
code423n4
opened
2 years ago
1
Immutable variables
#26
code423n4
opened
2 years ago
2
Use cached _ethBalance
#25
code423n4
opened
2 years ago
0
_processPerformanceFees is useless now
#24
code423n4
opened
2 years ago
1
Unused imports
#23
code423n4
closed
2 years ago
3
Frontrunning distribute functions
#22
code423n4
opened
2 years ago
0
events in BaseStrategy are never emitted
#21
code423n4
opened
2 years ago
1
Order of parameters in KickReward event
#20
code423n4
opened
2 years ago
1
Validations
#19
code423n4
opened
2 years ago
0
Functions not returning declared values
#18
code423n4
opened
2 years ago
1
Front running transaction possible as min_out_amount = 0 when swapping
#17
code423n4
closed
2 years ago
2
`reinvest` function should return a `uint256 reinvested` amount but it returns nothing
#16
code423n4
closed
2 years ago
2
The comments incorrectly indicate the range in which `toLock` input should be given.
#15
code423n4
opened
2 years ago
1
Declare CvxLocker erc20 contract variables as immutable
#14
code423n4
opened
2 years ago
1
Make variable veCVXStrategy::MAX_BPS constant
#13
code423n4
opened
2 years ago
1
Faulty return value in veCVXStrategy::reinvest()
#12
code423n4
opened
2 years ago
1
Next