code-423n4 2021-09-sushimiso-findings issues

code-423n4 / 2021-09-sushimiso-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Inconsistent Template Deletion

#151 code423n4 opened 3 years ago
0
Lack of Length Checking

#150 code423n4 closed 3 years ago
2
Inaccurate Function Name `enableList()`

#149 code423n4 opened 3 years ago
2
Missing `uint256` Cast

#148 code423n4 opened 3 years ago
2
Boring Batchable Delegate Call exploit?

#147 code423n4 closed 3 years ago
2
Frontrunning on the low level mint() call is possible in .finalize()

#146 code423n4 closed 3 years ago
2
PostAuctionLauncher can be manipulated by a caller other than the owner

#145 code423n4 closed 3 years ago
1
Improper Boolean Comparison

#144 code423n4 opened 3 years ago
1
Use a struct for raw data.

#143 code423n4 opened 3 years ago
1
Certain view functions should be used only by UI and not by the code

#142 code423n4 opened 3 years ago
2
Add input validation on some methods

#141 code423n4 opened 3 years ago
2
Using .transfer to send eth is bad practice.

#140 code423n4 closed 3 years ago
1
Use constructors instead of init functions

#139 code423n4 closed 3 years ago
2
Consider using a solidity version >= 0.8.0

#138 code423n4 opened 3 years ago
1
An adversarial attacker can initialize ListFactory

#137 code423n4 opened 3 years ago
1
Requiring a decimals method for ERC-20 tokens is non-standard

#136 code423n4 opened 3 years ago
2
Caching `totalPoints` during `setPoints` method

#135 code423n4 opened 3 years ago
1
Consider having short revert strings

#134 code423n4 opened 3 years ago
0
Use `calldata` instead of `memory` for function parameters

#133 code423n4 opened 3 years ago
1
## Caching the length in for loops

#132 code423n4 opened 3 years ago
0
Upgrade to at least 0.8.4

#131 code423n4 opened 3 years ago
1
Style issues

#130 code423n4 opened 3 years ago
2
Emit events when setting the initial values

#129 code423n4 closed 3 years ago
1
_addCommitment should check that address is not empty

#128 code423n4 opened 3 years ago
2
_startTime is always < 10000000000 when _endTime < 10000000000 (_endTime > _startTime)

#127 code423n4 opened 3 years ago
0
Pack structs tightly

#126 code423n4 opened 3 years ago
0
allDepositIds is pretty much useless

#125 code423n4 opened 3 years ago
0
PostAuctionLauncher's liquidity provision can be exploited

#124 code423n4 closed 3 years ago
1
Dead code

#123 code423n4 opened 3 years ago
0
Useless initialization to default value

#122 code423n4 opened 3 years ago
0
Cache storage access

#121 code423n4 closed 3 years ago
2
Unused imports

#120 code423n4 opened 3 years ago
2
Immutable variables

#119 code423n4 closed 3 years ago
2
Separate minter roles are not really necessary

#118 code423n4 opened 3 years ago
0
SushiToken transfers are broken due to wrong delegates accounting on transfers

#117 code423n4 opened 3 years ago
2
MISORecipe01 uses outdated interfaces

#116 code423n4 opened 3 years ago
2
Commitments can happen after already finalized

#115 code423n4 opened 3 years ago
2
`TokenVault` incorrectly tracks `userIndex`

#114 code423n4 opened 3 years ago
2
Inclusive checks

#113 code423n4 opened 3 years ago
0
`WETH9` does not emit `Approval` event on transfer

#112 code423n4 closed 3 years ago
2
`MISOMasterChef.setDevPercentage` should be capped

#111 code423n4 opened 3 years ago
2
The first escrow index underflows

#110 code423n4 opened 3 years ago
3
`HyperbolicAuction.initAuction` 's `_factor` argument is never used

#109 code423n4 opened 3 years ago
2
Loss of price precision

#108 code423n4 opened 3 years ago
2
Gas: Remove nonce from parameter list

#107 code423n4 opened 3 years ago
0
TokenInitialized token parameter is always empty

#106 code423n4 opened 3 years ago
3
Gas: Cache auction prices

#105 code423n4 opened 3 years ago
1
misoDiv might be empty for some time

#104 code423n4 closed 3 years ago
2
Use constant named variable for auction decimals

#103 code423n4 opened 3 years ago
3
Missing parameter validation

#102 code423n4 closed 3 years ago
3