issues
search
code-423n4
/
2021-10-defiprotocol-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Set initial value for lastFee
#91
code423n4
opened
2 years ago
1
Useless initialization
#90
code423n4
closed
2 years ago
1
Cache factory.ownerSplit()
#89
code423n4
opened
2 years ago
1
Cache basketAsERC20.totalSupply()
#88
code423n4
opened
2 years ago
2
There may be no bounties or user is not interested in any of them
#87
code423n4
opened
2 years ago
1
How much to approve before calling mintTo
#86
code423n4
opened
2 years ago
1
createBasket re-entrancy
#85
code423n4
opened
2 years ago
1
Validations
#84
code423n4
opened
2 years ago
1
mint will always revert
#83
code423n4
closed
2 years ago
2
Missing events for owner only functions that change critical parameters
#82
code423n4
opened
2 years ago
3
Missing events for basket only functions that change critical parameters
#81
code423n4
opened
2 years ago
2
Sensitive variables should not be able to be changed easily
#80
code423n4
opened
2 years ago
1
If newRatio > ibRatio after a settlement the protocol could lose its funds.
#79
code423n4
closed
2 years ago
2
Fee on transfer tokens do not work within the protocol
#78
code423n4
opened
2 years ago
1
Lack of Documentation on key functions
#77
code423n4
opened
2 years ago
1
Change function visibility from public to external to save gas
#76
code423n4
closed
2 years ago
1
Input Validation on Factory.sol
#75
code423n4
opened
2 years ago
1
Increase optimizer runs
#74
code423n4
opened
2 years ago
1
Remove hardhat import
#73
code423n4
opened
2 years ago
1
uint256 can be lowered to unitX with X < 256 in some cases
#72
code423n4
opened
2 years ago
1
Unchecked modifiers should be used when over/under-flow isnt an issue to save gas
#71
code423n4
opened
2 years ago
1
Uninitialized variables are automatically set to 0
#70
code423n4
opened
2 years ago
1
Unused imports
#69
code423n4
closed
2 years ago
1
`Basket.sol` should use the Upgradeable variant of OpenZeppelin Contracts
#68
code423n4
opened
2 years ago
1
`Basket.sol#initialize()` Remove redundant assertion can save gas
#67
code423n4
closed
2 years ago
1
`Factory.sol#constructor` Remove redundant code can save gas
#66
code423n4
closed
2 years ago
1
`Basket.sol#initialize()` Remove redundant code can save gas
#65
code423n4
closed
2 years ago
1
`Basket.sol#changePublisher()` Remove redundant assertion can save gas
#64
code423n4
opened
2 years ago
1
Basket: No need for initialized variable
#63
code423n4
opened
2 years ago
1
`Basket.sol#changeLicenseFee()` Remove redundant check can save gas
#62
code423n4
opened
2 years ago
1
`Basket.sol#changePublisher()` Insufficient input validation
#61
code423n4
opened
2 years ago
1
`Basket.sol` should have methods to cancel pending changes
#60
code423n4
opened
2 years ago
1
`Basket.sol#mint()` Malfunction due to extra `nonReentrant` modifier
#59
code423n4
opened
2 years ago
1
Tests are broken
#58
code423n4
opened
2 years ago
1
Unnecessary nonReentrant at mint breaks protocol
#57
code423n4
closed
2 years ago
2
Unnecessary new list in Basket's validateWeights()
#56
code423n4
opened
2 years ago
1
Pack together bool variables in Auction
#55
code423n4
closed
2 years ago
1
Unnecessary initializing of variable to 0
#54
code423n4
closed
2 years ago
2
Restore state to 0 if not needed anymore
#53
code423n4
opened
2 years ago
1
Redundant call to external contract, result can be saved
#52
code423n4
closed
2 years ago
2
Auction bonder can steal user funds if bond block is high enough
#51
code423n4
opened
2 years ago
4
Inaccurate log emitted at deleteNewIndex
#50
code423n4
opened
2 years ago
2
Basket becomes unusable if everybody burns their shares
#49
code423n4
opened
2 years ago
2
Bonding mechanism allows malicious user to DOS auctions
#48
code423n4
opened
2 years ago
4
Comparisons to boolean constant
#47
code423n4
opened
2 years ago
1
Minimize Storage Slots (Auction.sol)
#46
code423n4
opened
2 years ago
2
`nonReentrant` modifier should be used before any other modifier
#45
code423n4
opened
2 years ago
1
Events in `IAuction` don't use the `indexed` keyword
#44
code423n4
opened
2 years ago
1
`Factory.proposeBasketLicense()` and `IFactory.proposeBasketLicense()` accept arguments with different data locations
#43
code423n4
opened
2 years ago
1
`Basket.publishNewIndex()` and `IBasket.publishNewIndex()` accept arguments with different data locations
#42
code423n4
opened
2 years ago
1
Next