code-423n4 2021-11-fei-findings issues

code-423n4 / 2021-11-fei-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Comparison with literal boolean values

#160 code423n4 opened 2 years ago
2
Unused local variables in requery (TRIBERagequit.sol)

#159 code423n4 opened 2 years ago
1
preMergeCirculatingTribe can be constant (TRIBERagequit.sol)

#158 code423n4 closed 2 years ago
2
Assignment Of State Variables To Default

#157 code423n4 opened 2 years ago
2
Boolean equality

#156 code423n4 closed 2 years ago
2
TribeRagequit : the value of token1OutBase will always have a decreasing trend

#155 code423n4 closed 2 years ago
2
Both contracts PegExchanger & TribeRagequit emit events with same name 'Exchange'

#154 code423n4 closed 2 years ago
2
PegExchanger : Its possible to extend the Redemption Period again by the tribe (party1) timelock

#153 code423n4 closed 2 years ago
2
PegExchanger : After proposal enabled, users allowed to exchange even if the expirationBlock is not set.

#152 code423n4 closed 2 years ago
2
unsafe cast

#151 code423n4 opened 2 years ago
1
denial of service

#150 code423n4 opened 2 years ago
2
PegExchanger expiry block must be set to at least `MIN_EXPIRY_WINDOW + 1` into the future

#149 code423n4 opened 2 years ago
1
`requery()` has unused local variables

#148 code423n4 closed 2 years ago
2
`preMergeCirculatingTribe` can be constant

#147 code423n4 opened 2 years ago
1
`transferFrom` external call can be done inside require statement

#146 code423n4 closed 2 years ago
2
No restriction for expiration block in PegExchange.sol

#145 code423n4 closed 2 years ago
2
No restriction for expiration block in TRIBERagequit.sol

#144 code423n4 opened 2 years ago
3
Don't cache bool `check`

#143 code423n4 opened 2 years ago
2
Add events for party accepts

#142 code423n4 closed 2 years ago
3
== true has no effect

#141 code423n4 closed 2 years ago
2
Use negate(!) rather than == false

#140 code423n4 closed 2 years ago
2
Some functions could be declared external rather than public

#139 code423n4 closed 2 years ago
2
Not used return value at recalculate and requery in TRIBERagequit.sol

#138 code423n4 opened 2 years ago
2
Make merkleRoot immutable

#137 code423n4 closed 2 years ago
2
TRIBERagequit.sol#recalculate should be internal

#136 code423n4 closed 2 years ago
2
Wrong comments about key in TRIBERagequit

#135 code423n4 opened 2 years ago
1
Loops can be implemented more efficiently

#134 code423n4 opened 2 years ago
1
For uint `> 0` can be replaced with ` != 0` for gas optimization

#133 code423n4 closed 2 years ago
2
Some public functions can be defined as external to save gas

#132 code423n4 closed 2 years ago
2
In TRIBERagequit.sol, users can get frontrunned

#131 code423n4 opened 2 years ago
2
Boolean comparisons in require statements

#130 code423n4 closed 2 years ago
2
There is no need to assign default values to variables

#129 code423n4 closed 2 years ago
2
Missing Allowance Check

#128 code423n4 closed 2 years ago
2
Redundant Check On The Contract check

#127 code423n4 closed 2 years ago
2
Value of token1OutBase might became stale in TRIBERagequit.sol

#126 code423n4 opened 2 years ago
2
Gas Optimization: Unused return variables in TRIBERagequit.sol

#125 code423n4 closed 2 years ago
2
Gas Optimization: Unchecked safe logic in TRIBERagequit.sol

#124 code423n4 opened 2 years ago
1
Gas Optimization: Inline transfer in TRIBERagequit.sol

#123 code423n4 closed 2 years ago
2
Inaccurate revert reason in TRIBERagequit.sol

#122 code423n4 opened 2 years ago
1
Gas Optimization: Unchecked safe logic in PegExchanger.sol

#121 code423n4 closed 2 years ago
2
Gas Optimization: Inline transfer in PegExchanger.sol

#120 code423n4 closed 2 years ago
2
Gas Optimization: Inline checking in PegExchanger.sol

#119 code423n4 closed 2 years ago
2
Functions unused internally marked public

#118 code423n4 closed 2 years ago
2
An unchanging variable not declared constant

#117 code423n4 closed 2 years ago
2
Gas: `balanceStrings` computed twice

#116 code423n4 closed 2 years ago
2
`recalculate` does not need to be public

#115 code423n4 closed 2 years ago
2
Oracle validity not checked in requery() / TRIBERagequit.sol

#114 code423n4 closed 2 years ago
2
Ragequit has missing min return amount checks

#113 code423n4 closed 2 years ago
2
Wrong `preMergeCirculatingTribe` value

#112 code423n4 opened 2 years ago
2
PegExchanger's fixed price leads to arbitrage

#111 code423n4 closed 2 years ago
2