code-423n4 2021-11-vader-findings issues

code-423n4 / 2021-11-vader-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Check that all transfers don't result in violation of max supply is unnecessary

#220 code423n4 closed 2 years ago
0
Disregarding Check Effects in `VaderBond.redeem()`

#219 code423n4 opened 3 years ago
4
ERC20 Return values not checked

#218 code423n4 closed 2 years ago
1
Potential economic attack that exploits IL coverage

#217 code423n4 closed 3 years ago
1
`VaderMath.sol#calculateSwap()` Wrong design/implementation of slippage control

#216 code423n4 closed 2 years ago
2
Critical changes should use two-step procedure

#215 code423n4 closed 2 years ago
0
Missing events for critical operations

#214 code423n4 opened 3 years ago
2
Wrong design of `swap()` results in unexpected and unfavorable outputs

#213 code423n4 opened 3 years ago
3
Wrong design/implementation of `addLiquidity()` allows attacker to steal funds from the liquidity pool

#212 code423n4 opened 3 years ago
3
Combine external calls into one can save gas

#211 code423n4 closed 2 years ago
1
`Synth` tokens can get over-minted

#210 code423n4 closed 2 years ago
1
`mintSynth()` and `burnSynth()` can be front run

#209 code423n4 opened 3 years ago
0
Adding unchecked directive can save gas

#208 code423n4 closed 3 years ago
1
Changing function visibility from public to external can save gas

#207 code423n4 opened 3 years ago
0
`SwapQueue.sol` Incomplete implementation

#206 code423n4 opened 3 years ago
0
`USDV.sol` Incomplete implementation

#205 code423n4 opened 3 years ago
0
Lack of access control allow attacker to `mintFungible()` and `mintSynth()` with other user's wallet balance

#204 code423n4 opened 3 years ago
3
`GasThrottle#validateGas()` Code should be uncommented

#203 code423n4 closed 3 years ago
1
VaderBond insufficient validation of max payout may prevent redeeming valid payout

#202 code423n4 opened 3 years ago
2
Avoid unnecessary storage read can save gas

#201 code423n4 closed 2 years ago
0
Unnecessary storage variables can be changed to `immutable` to save gas

#200 code423n4 closed 2 years ago
0
`Router#initialize()` Lack of input validation for `reserve` asset

#199 code423n4 opened 3 years ago
0
Possibility of reducing the maxSupply of Vader

#198 code423n4 opened 3 years ago
1
Use short reason strings can save gas

#197 code423n4 closed 3 years ago
1
Cache array length in for loops can save gas

#196 code423n4 closed 3 years ago
1
Unsafe type casting

#195 code423n4 opened 3 years ago
3
`BasePoolV2#_supportedToken(IERC20 token)` is only used in `modifier supportedToken(IERC20 token)`

#194 code423n4 closed 2 years ago
2
Tokens with fee on transfer are not supported

#193 code423n4 opened 3 years ago
3
`BasePoolV2.sol` reserve should not be allowed to be 0

#192 code423n4 closed 2 years ago
2
`BasePoolV2#rescue()` should be `nonReentrant`

#191 code423n4 opened 3 years ago
3
`VaderRouterV2#addLiquidity()` is not compatible with the interface of UniswapV2Router02#addliquidity()

#190 code423n4 opened 3 years ago
0
Early user can break `addLiquidity`

#189 code423n4 opened 3 years ago
2
Wrong comment in `vaderToUsdv`

#188 code423n4 closed 2 years ago
3
XVader.sol : loss of user funds during 'leave' function

#187 code423n4 closed 3 years ago
1
Governance veto can be bypassed

#186 code423n4 opened 3 years ago
3
Gas Optimization: Unchecked block

#185 code423n4 closed 3 years ago
1
Gas Optimization: Simplify Math

#184 code423n4 opened 3 years ago
0
Gas Optimization: Inline instead of modifier

#183 code423n4 opened 3 years ago
0
Attacker can claim more IL by manipulating pool price then `removeLiquidity`

#182 code423n4 opened 3 years ago
3
Use safeTransfer instead of transfer

#181 code423n4 opened 3 years ago
3
Vader

#180 code423n4 closed 2 years ago
1
Open TODOs

#179 code423n4 closed 3 years ago
1
block.chainid may change in case of a hardfork

#178 code423n4 opened 3 years ago
1
Adding unchecked directive can save gas

#177 code423n4 closed 3 years ago
1
Revert String Size Optimization

#176 code423n4 closed 3 years ago
1
No Transfer Ownership Pattern

#175 code423n4 opened 3 years ago
0
Gas: `setPaused` should use `_paused`

#174 code423n4 closed 3 years ago
1
Unclear `TwapOracle.consult` algorithm

#173 code423n4 closed 2 years ago
1
`TWAPOracle.getRate` does not scale the ratio

#172 code423n4 closed 2 years ago
1
TWAPOracle might register with wrong token order

#171 code423n4 closed 2 years ago
1

Previous Next