code-423n4 2021-12-amun-findings issues

code-423n4 / 2021-12-amun-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Gas saving

#147 code423n4 closed 2 years ago
1
Gas saving

#146 code423n4 closed 2 years ago
1
Gas saving

#145 code423n4 opened 2 years ago
0
INTERMEDIATE_TOKEN call does not check return value

#144 code423n4 closed 2 years ago
1
In loops, storage array length can be cached in memory

#143 code423n4 closed 2 years ago
1
Basket's max cap can be surpassed due to beneficiary entry fee

#142 code423n4 closed 2 years ago
1
Gas can be saved in the `calcTokensForAmount()` loop

#141 code423n4 opened 2 years ago
0
Locking logic in Rebalancers can be changed to avoid SSTOREs.

#140 code423n4 opened 2 years ago
0
Unused state variables in MintableERC20

#139 code423n4 opened 2 years ago
0
Unlocked compiler version

#138 code423n4 opened 2 years ago
0
Typo in event name

#137 code423n4 opened 2 years ago
0
Lacking zero address checks

#136 code423n4 opened 2 years ago
1
Unchecked ERC20 transfer call

#135 code423n4 closed 2 years ago
2
Use of unsafe transfer()

#134 code423n4 closed 2 years ago
2
Lacking slippage protection in RebalanceManagerV3

#133 code423n4 closed 2 years ago
2
Possible DoS attack in SingleTokenJoin.sol

#132 code423n4 closed 2 years ago
1
SingleJoin/SingleExit contracts use `transfer()` to send ether back to the caller

#131 code423n4 closed 2 years ago
1
SingleNativeTokenExitV2 and JoinV2 will approve any premade contract for unlimited spending

#130 code423n4 closed 2 years ago
2
Zero transfers

#129 code423n4 opened 2 years ago
0
Open TODOs

#128 code423n4 closed 2 years ago
2
Incompatibility With Rebasing/Deflationary/Inflationary tokens

#127 code423n4 closed 2 years ago
1
BasketFacet.MIN_AMOUNT doesn't take into account token's decimals

#126 code423n4 closed 2 years ago
1
Missing validation of address argument could indefinitely lock RebalanceManager contracts

#125 code423n4 opened 2 years ago
1
Missing checks if pairs equal tokens

#124 code423n4 opened 2 years ago
1
Output token is obtained from the first trade in SingleNativeTokenExitV2.exit

#123 code423n4 closed 2 years ago
2
Restrict funds receivable to be only from wrapped native token

#122 code423n4 closed 2 years ago
1
Unused INTERMEDIATE_TOKEN On the Contracts

#121 code423n4 closed 2 years ago
1
Less than 256 uints are not gas efficient

#120 code423n4 opened 2 years ago
0
ERC20 approve method missing return value check

#119 code423n4 closed 2 years ago
1
`> 0 can be replaced with != 0 for gas optimization`

#118 code423n4 closed 2 years ago
1
Use a constant instead of block.timestamp for the deadline

#117 code423n4 opened 2 years ago
0
Possible Re-entrancy

#116 code423n4 opened 2 years ago
2
Cache array length in for loops can save gas

#115 code423n4 closed 2 years ago
1
SingleJoin/SingleExit ignore the return value of ERC20.approve

#114 code423n4 closed 2 years ago
1
EthSingleTokenJoin allows initialization with an intermediate token other than WETH breaking its functionality

#113 code423n4 closed 2 years ago
2
Wrong Deadline

#112 code423n4 closed 2 years ago
1
Revert String Size Optimization

#111 code423n4 opened 2 years ago
0
Use safeTransfer/safeTransferFrom consistently instead of transfer/transferFrom

#110 code423n4 closed 2 years ago
2
Missing slippage/min-return check in the `uniSwapLikeRouter ` contract

#109 code423n4 closed 2 years ago
1
++i is more gas efficient than i++ in loops forwarding

#108 code423n4 opened 2 years ago
0
Delete - ABI Coder V2 For Gas Optimization

#107 code423n4 opened 2 years ago
1
Upgrade pragma to at least 0.8.4

#106 code423n4 opened 2 years ago
0
Use of _msgSender()

#105 code423n4 opened 2 years ago
0
LibBasketStorage exitFeeBeneficiaryShare comment is misleading

#104 code423n4 closed 2 years ago
2
Fee on transfer tokens will provide user less than minimum return amount requested from SingleNativeTokenExitV2.exit

#103 code423n4 closed 2 years ago
1
potential denial of service

#102 code423n4 closed 2 years ago
1
underflow in rebalance can cause unexpected behavior

#101 code423n4 closed 2 years ago
1
protectedCall shared modifier can be bypassed on all functions by registered callers by using singleCall / call / callNoValue on the contract's own address, impersonating the contract in reference to itself

#100 code423n4 closed 2 years ago
1
ERC20Facet, MintableERC20 and PolygonERC20Wrapper contracts initialization can be front run

#99 code423n4 closed 2 years ago
1
All join contracts can be disabled permanently

#98 code423n4 closed 2 years ago
1

Previous Next