issues
search
code-423n4
/
2021-12-amun-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Cache array length in for loops can save gas
#197
code423n4
closed
2 years ago
1
Intermediate max-input-amount check in `_joinTokenSingle` is unnecessary
#196
code423n4
opened
2 years ago
0
Gas: Intermediate min-return check in `_joinTokenSingle` is unnecessary
#195
code423n4
opened
2 years ago
0
`_joinTokenSingle` can easily fail
#194
code423n4
opened
2 years ago
0
SingleNativeTokenExitV2 only returns single output token
#193
code423n4
closed
2 years ago
2
ERC20 return values not checked
#192
code423n4
opened
2 years ago
3
Usage of address.transfer
#191
code423n4
closed
2 years ago
1
Wrapped native token is assumed as the `INTERMEDIATE_TOKEN`
#190
code423n4
opened
2 years ago
0
Same facet can be added several times
#189
code423n4
opened
2 years ago
0
Unchecked return value for `ERC20.approve` call
#188
code423n4
closed
2 years ago
1
Loss of precision when calculating the annualized fee
#187
code423n4
closed
2 years ago
1
Rebalance manager can steal tokens
#186
code423n4
opened
2 years ago
2
`initialize` functions can be frontrun
#185
code423n4
opened
2 years ago
1
Use `IWrappedNativeToken.deposit()` can save some gas
#184
code423n4
opened
2 years ago
0
User could get approval for all of SingleTokenJoinV2 tokens
#183
code423n4
closed
2 years ago
1
User could get approval for all of SingleTokenJoin tokens
#182
code423n4
closed
2 years ago
1
User could get approval for all of SingleNativeTokenExitV2 tokens
#181
code423n4
closed
2 years ago
1
Unused variable uniSwapLikeRouter in SingleNativeTokenExitV2
#180
code423n4
closed
2 years ago
1
Assigning keccak operations to constant variables results in extra gas costs
#179
code423n4
closed
2 years ago
1
Useless imports
#178
code423n4
closed
2 years ago
1
Unnecessary struct in SingleNativeTokenExitV2
#177
code423n4
opened
2 years ago
0
SingleNativeTokenExitV2 assumes first exchange holds the outputToken
#176
code423n4
opened
2 years ago
0
Don't use transfer()
#175
code423n4
opened
2 years ago
0
Change function visibility from public to external
#174
code423n4
opened
2 years ago
0
Some tokens don't allow to set a non-zero approval from a non-zero approval
#173
code423n4
closed
2 years ago
1
denial of service
#172
code423n4
closed
2 years ago
1
Only pass lockBlock as parameter instead of LibBasketStorage.basketStorage()
#171
code423n4
opened
2 years ago
0
SingleTokenJoinV2 doesn't take input deadline to consideration
#170
code423n4
closed
2 years ago
2
SingleNativeTokenExitV2 doesn't take input deadline to consideration
#169
code423n4
closed
2 years ago
2
Many commonly used tokens do not return a boolean from IERC20.approve(); some methods will revert for these tokens
#168
code423n4
closed
2 years ago
1
pointless amountOutMin
#167
code423n4
opened
2 years ago
1
1
#166
code423n4
closed
2 years ago
1
Consider sending native token using .call instead of .transfer
#165
code423n4
closed
2 years ago
1
No check for fund source in SingleNativeTokenExitV2 receive function
#164
code423n4
closed
2 years ago
1
No check for fund source in SingleNativeTokenExit receive function
#163
code423n4
closed
2 years ago
1
No check for fund source in EthSingleTokenJoinV2 receive function
#162
code423n4
closed
2 years ago
1
No check for fund source in EthSingleTokenJoin receive function
#161
code423n4
closed
2 years ago
1
Gas saving
#160
code423n4
closed
2 years ago
1
Basket might be unusable after initialization due to _initialSupply = 0
#159
code423n4
opened
2 years ago
1
Unnecessary use of Safemath
#158
code423n4
closed
2 years ago
1
Gas saving
#157
code423n4
closed
2 years ago
1
Gas saving
#156
code423n4
closed
2 years ago
1
Lost annualized fees due to early division
#155
code423n4
opened
2 years ago
1
Gas saving
#154
code423n4
closed
2 years ago
1
Integer overflow
#153
code423n4
closed
2 years ago
1
Consider making some constants as non-public to save gas
#152
code423n4
opened
2 years ago
0
A more efficient for loop index proceeding
#151
code423n4
closed
2 years ago
1
Gas saving
#150
code423n4
closed
2 years ago
1
Gas saving
#149
code423n4
closed
2 years ago
1
Upgrading the solc compiler to >=0.8 may save gas
#148
code423n4
closed
2 years ago
3
Previous
Next