issues
search
code-423n4
/
2021-12-amun-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
For uint `> 0` can be replaced with ` != 0` for gas optimization
#247
code423n4
closed
2 years ago
1
Cache `bs.token.length` in `BacketFacet.sol`
#246
code423n4
closed
2 years ago
1
Gas Optimization: Struct layout
#245
code423n4
closed
2 years ago
1
Due to lack of input validation , self transfer can happen
#244
code423n4
opened
2 years ago
1
No minimum fees is defined
#243
code423n4
opened
2 years ago
1
`totalSupply` may go above `this.getCap()`
#242
code423n4
closed
2 years ago
1
Lack of access modifier in Initialize()
#241
code423n4
opened
2 years ago
0
Missing zero address check in setDefaultController
#240
code423n4
opened
2 years ago
1
Fee-on-transfer token not supported
#239
code423n4
closed
2 years ago
3
Dos in callFacet.call()
#238
code423n4
closed
2 years ago
1
Unchecked return value from low-level call()
#237
code423n4
opened
2 years ago
2
Mul after Div
#236
code423n4
closed
2 years ago
1
Gas Optimization: Use of immutable instead of constant keccak expression
#235
code423n4
closed
2 years ago
1
Gas Optimization: Cache length for iterations
#234
code423n4
closed
2 years ago
1
unchecked return value from approve()
#233
code423n4
closed
2 years ago
1
unchecked return value from transfer()
#232
code423n4
closed
2 years ago
1
use of transfer() instead of call() to send eth
#231
code423n4
closed
2 years ago
1
Use of floating pragma
#230
code423n4
opened
2 years ago
0
Improper design/implementation of `SingleTokenJoinV2#joinTokenSingle()` make it prone to fail
#229
code423n4
closed
2 years ago
2
Lack of zero-address checks
#228
code423n4
opened
2 years ago
0
Internal call is more efficient than external call
#227
code423n4
opened
2 years ago
0
`RebalanceManager.sol#setRebalanceManager()` should implement two-step transfer pattern
#226
code423n4
opened
2 years ago
1
Avoid unnecessary external calls can save gas
#225
code423n4
opened
2 years ago
0
wrong withdraw
#224
code423n4
closed
2 years ago
2
Upgrade pragma to at least 0.8.4 is more gas efficient
#223
code423n4
closed
2 years ago
1
Precision loss due to `div` before `mul`
#222
code423n4
closed
2 years ago
1
`BasketFacet.sol#joinPool()` `feeAmount` should be considered when checking `MAX_POOL_CAP_REACHED`
#221
code423n4
closed
2 years ago
1
Tokens with fee on transfer are not supported
#220
code423n4
opened
2 years ago
0
`PolygonERC20Wrapper.sol` Avoid unnecessary storage operations can save gas
#219
code423n4
closed
2 years ago
2
Redundant check on feeBeneficiaryShare
#218
code423n4
closed
2 years ago
1
MintableERC20 tokens might get stuck in ERC20PREDICATE purgatory for all eternity
#217
code423n4
closed
2 years ago
1
not minting
#216
code423n4
closed
2 years ago
2
`SingleTokenJoin#joinTokenSingle()` Change `inputAmount` to `maxInputAmount` can avoid dust INTERMEDIATE_TOKEN and save gas
#215
code423n4
opened
2 years ago
0
Remove unnecessary variables can make the code simpler and save some gas
#214
code423n4
opened
2 years ago
0
Reuse operation results can save gas
#213
code423n4
opened
2 years ago
0
Attacker can break `joinTokenSingle()` by transferring basketToken to the contract
#212
code423n4
closed
2 years ago
1
PolygonERC20Wrapper does not need to be ERC20
#211
code423n4
opened
2 years ago
0
`++s.lockCounter` is more efficient than `s.lockCounter++` for storage variable
#210
code423n4
closed
2 years ago
1
Use short circuiting can save gas
#209
code423n4
opened
2 years ago
0
PolygonERC20Wrapper can emit burn event instead of calling ERC20 functions
#208
code423n4
opened
2 years ago
0
Avoid unnecessary storage read can save gas
#207
code423n4
opened
2 years ago
0
Only using `SafeMath` when necessary can save gas
#206
code423n4
closed
2 years ago
1
Avoid repeated arithmetic operations in for loop can save gas
#205
code423n4
opened
2 years ago
0
`PolygonERC20Wrapper.sol` Use immutable variable can save gas
#204
code423n4
closed
2 years ago
1
`10 ** 18` can be changed to `1e18` and save some gas
#203
code423n4
opened
2 years ago
0
`ReentryProtection.sol` Switching between 1, 2 instead of increasing `lockCounter` is more gas efficient
#202
code423n4
opened
2 years ago
0
Unused ERC20 tokens are not refunded, and can be stolen by attacker
#201
code423n4
opened
2 years ago
0
input amount might be wrong
#200
code423n4
opened
2 years ago
1
`transfer()` is not recommended for sending ETH
#199
code423n4
closed
2 years ago
1
Unsafe token transfer
#198
code423n4
closed
2 years ago
2
Previous
Next