issues
search
code-423n4
/
2021-12-defiprotocol-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
> 0 can be replaced with != 0 for gas optimisation
#127
code423n4
closed
2 years ago
1
`Auction.sol#initialize()` Use msg.sender rather than factory_ parameter can save gas
#126
code423n4
opened
2 years ago
0
A more efficient for loop index proceeding
#125
code423n4
closed
2 years ago
1
Cache array length in for loops can save gas
#124
code423n4
closed
2 years ago
1
Adding unchecked directive can save gas
#123
code423n4
opened
2 years ago
0
Cache external call results can save gas
#122
code423n4
opened
2 years ago
0
Unnecessary checked arithmetic in for loops
#121
code423n4
opened
2 years ago
0
`++i` is more efficient than `i++`
#120
code423n4
opened
2 years ago
0
Cache array length in for loops can save gas
#119
code423n4
closed
2 years ago
1
`validateWeights()` Limit loop to a meaningful bound can save gas
#118
code423n4
opened
2 years ago
0
Use free functions to replace external calls can save gas
#117
code423n4
opened
2 years ago
0
Use approve(0) first
#116
code423n4
closed
2 years ago
1
`NewIndexSubmitted` event is not emitted in some case
#115
code423n4
opened
2 years ago
2
A variable is being assigned its default value
#114
code423n4
closed
2 years ago
1
Useless imports
#113
code423n4
opened
2 years ago
0
Critical operations should emit events
#112
code423n4
opened
2 years ago
0
`Factory.sol` Lack of two-step procedure and/or input validation routines for critical operations leaves them error-prone
#111
code423n4
opened
2 years ago
0
`Basket.sol#handleFees()` Check if `timeDiff > 0` can save gas
#110
code423n4
opened
2 years ago
0
External visibility should be preferred
#109
code423n4
closed
2 years ago
1
`Basket.sol#publishNewIndex()` Lack of input validation may cause fund loss to anyone who bonds an auction
#108
code423n4
closed
2 years ago
2
`Auction.sol#auctionOngoing` Switching between 1, 2 instead of true, false is more gas efficient
#107
code423n4
opened
2 years ago
0
`Auction.sol#settleAuction()` Bonder may not be able to settle a bonded auction, leading to loss of funds
#106
code423n4
opened
2 years ago
1
`Basket.sol#pullUnderlying()` Cache and read storage variables from the stack can save gas
#105
code423n4
closed
2 years ago
1
`Basket.sol` should use the Upgradeable variant of OpenZeppelin Contracts
#104
code423n4
opened
2 years ago
0
`Basket.sol` Pending licenseFee may unable to be canceled when current licenseFee is `0`
#103
code423n4
opened
2 years ago
2
Reorder storage variable to save gas
#102
code423n4
closed
2 years ago
1
Function can be external
#101
code423n4
closed
2 years ago
1
`Basket.sol#approveUnderlying()` Cache and read storage variables from the stack can save gas
#100
code423n4
opened
2 years ago
0
Function can be external
#99
code423n4
closed
2 years ago
1
Avoid unnecessary storage read can save gas
#98
code423n4
closed
2 years ago
2
`Basket.sol#changeLicenseFee()` Unable to set `licenseFee` to 0
#97
code423n4
opened
2 years ago
1
`Basket.sol#changePublisher()` Remove redundant assertion can save gas
#96
code423n4
closed
2 years ago
1
`Basket.sol#initialize()` Remove redundant storage and code can save gas
#95
code423n4
closed
2 years ago
1
Setting `uint256` variables to `0` is redundant
#94
code423n4
closed
2 years ago
1
Missing error messages in require statements
#93
code423n4
opened
2 years ago
0
`Basket.sol#initialize()` Remove redundant assertion can save gas
#92
code423n4
opened
2 years ago
0
Unused imports
#91
code423n4
opened
2 years ago
0
Outdated compiler version
#90
code423n4
opened
2 years ago
0
Runtime constants not defined as immutable
#89
code423n4
closed
2 years ago
1
Broken unit tests due to incorrect values
#88
code423n4
opened
2 years ago
2
Factory Constructor Does Not Check for Zero Addresses
#87
code423n4
closed
2 years ago
1
Repeat SLOAD weights During Loop in Multiple Functions is Waste of Gas
#86
code423n4
closed
2 years ago
1
Use safeIncreaseAllowance() Instead of Deprecated safeApprove()
#85
code423n4
closed
2 years ago
1
Avoid Initialization of Loop Index If It Is 0 to Save Gas
#84
code423n4
opened
2 years ago
0
setAuctionDecrement() Lack of Input Validation May Break Other Function
#83
code423n4
opened
2 years ago
2
setAuctionMultiplier() Lack of Input Validation May Break Other Function
#82
code423n4
opened
2 years ago
2
TODOs List May Leak Important Info & Errors
#81
code423n4
closed
2 years ago
1
DOS attack - BondForRebalance
#80
code423n4
closed
2 years ago
2
Use local variables when emitting `ChangedPublisher` and `ChangedLicenseFee`
#79
code423n4
closed
2 years ago
1
Set allowance only once when initializing a basket
#78
code423n4
closed
2 years ago
1
Previous
Next